-
Notifications
You must be signed in to change notification settings - Fork 4
enhance move feeder #3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
enhance move feeder #3416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have sonar issues and minor thing
update your pr with main
| export const CONNECTION_DIRECTIONS_VALUES = { | ||
| TOP: { id: 'TOP', label: 'Top' }, | ||
| BOTTOM: { id: 'BOTTOM', label: 'Bottom' }, | ||
| UNDEFINED: { id: 'UNDEFINED', label: 'Undefined' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 2 or 3 undefined in trad dictionnary, should it be harmonize here ?
|
| (feederBaysInfos: FeederBaysInfos, busBarSectionInfos: string[]) => { | ||
| let mergedRowData: FeederBaysFormInfos[] = []; | ||
| if (!editData?.uuid && feederBaysInfos.length > 0) { | ||
| console.log('================feederBaysInfos', feederBaysInfos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log ?



No description provided.