Enhance busbar sections retrieval – rework BusbarSectionFinderTraverser #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
# Conflicts: # src/main/java/org/gridsuite/network/map/dto/definition/extension/BusbarSectionFinderTraverser.java
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
Signed-off-by: Etienne Homer <[email protected]>
etiennehomer
changed the title
etiennehomer
commented
Oct 6, 2025
|
|
||
| private Network network; | ||
|
|
||
| public static void createSwitch(VoltageLevel vl, String id, SwitchKind kind, boolean open, int node1, int node2) { |
There was a problem hiding this comment.
make public createSwitch() from NetworkMapControllerTest and use it
etiennehomer
commented
Oct 6, 2025
| */ | ||
|
|
||
| @SpringBootTest | ||
| public class BusbarSectionFinderTraverserTest { |
There was a problem hiding this comment.
You can remove ConnectablePosition and BusbarSectionPosition from all the equipments
There was a problem hiding this comment.
Ok no. The SLD is dirty without the position. Let's keep it
There was a problem hiding this comment.
ConnectablePosition removed
etiennehomer
commented
Oct 6, 2025
| } | ||
|
|
||
| @Test | ||
| void testWithClosedSwitch() { |
There was a problem hiding this comment.
Suggested change
| void testWithClosedSwitch() { | |
| void testWithClosedLastSwitch() { |
etiennehomer
commented
Oct 6, 2025
| network.getSwitch("DISC_BUS1_1").setOpen(false); | ||
| Line line11 = network.getLine("LINE_1_1"); | ||
| Line line21 = network.getLine("LINE_2_1"); | ||
| BusbarSectionFinderTraverser.BusbarSectionResult result11 = BusbarSectionFinderTraverser.getBusbarSectionResult(line11.getTerminal1()); |
There was a problem hiding this comment.
Remove this traverse ? it's AllClosedSwitch and it's almost the same as the traverse below
etiennehomer
commented
Oct 6, 2025
| } | ||
|
|
||
| @Test | ||
| void testWithOpenSwitch() { |
There was a problem hiding this comment.
Suggested change
| void testWithOpenSwitch() { | |
| void testWithOpenLastSwitch() { |
|
ghazwarhili
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.