Replace modification report when building variant #670
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayoub LABIDI <[email protected]>
TheMaskedTurtle
approved these changes
Aug 20, 2025
| } | ||
|
|
||
| public void sendReport(UUID reportUuid, ReportNode reportNode) { | ||
| public void sendReport(UUID reportUuid, ReportNode reportNode, boolean isVariantBuild) { |
There was a problem hiding this comment.
Maybe one method sendReport and another one sendAndReplaceReport ?
| } | ||
|
|
||
| private ApplicationStatus apply(ModificationApplicationGroup modificationGroupInfos, NetworkStoreListener listener) { | ||
| private ApplicationStatus apply(ModificationApplicationGroup modificationGroupInfos, NetworkStoreListener listener, boolean isVariantBuild) { |
There was a problem hiding this comment.
Maybe isIncremental ? I don't know I feel like I don't understand easily this isVariantBuild boolean
…cation-report-when-building-variant
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.