No longer block the tomcat thread when waiting for import or export (servlet 3.0+ AsyncContext) #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the computations This requires to reorganize the code and the transactions the fully load the data, hence the changes in NetworkModificationRepository with the new intermediate methods. Add testInsertCompositeModifications for symmetry with other code paths duplicate/move/ in the switch/case of ModificationController ?action=...
…pool for large modifications)
jonenst
force-pushed
the
applynoblocktomcat
branch
from
5afdbb3 to
a72ef8d
Compare
…servlet 3.0+ AsyncContext) Add no timeout configuration to behave like before this change Spring forces us to adapt the tests with boilerplate code (asyncStarted() and asyncDispatch()) as per https://docs.spring.io/spring-framework/reference/testing/mockmvc/hamcrest/async-requests.html to mimic the servlet 3.0 redispatch Add more andReturn and assignement to variables to avoid potential mistakes The two mvc result represent the same request, inside they hold the same request/response objects, but some other fields are different (asyncResult for example) and tests may be unreliable if they use the first one (representing the state before the async split)
jonenst
force-pushed
the
applynoblocktomcat
branch
from
a72ef8d to
79b4b61
Compare
jonenst
force-pushed
the
applynoblocktomcat
branch
from
3449380 to
fb438ca
Compare
klesaulnier
approved these changes
Oct 10, 2025
|
example of parallel schedule in NetworkModificationService (drop in replacement in scheduleApplyModifications) private static CompletableFuture<Void> scheduleApplyModifications(
Function<ModificationApplicationContext, CompletableFuture<Optional<NetworkModificationResult>>> func,
List<ModificationApplicationContext> applicationContexts,
List<CompletableFuture<Optional<NetworkModificationResult>>> results) {
return CompletableFuture.completedFuture(null).thenCompose(unused -> {
for (ModificationApplicationContext applicationContext : applicationContexts) {
var cf = func.apply(applicationContext);
results.add(cf);
}
return CompletableFuture.allOf(results.toArray(new CompletableFuture[0]));
});
}Behaves the same with respect to exceptions (completes execeptionally, doesn't throw) |
jonenst
force-pushed
the
applysamethreadflush
branch
from
621c489 to
7d5828e
Compare
SlimaneAmar
force-pushed
the
applynoblocktomcat
branch
from
3733c57 to
8cd1350
Compare
|
when waiting for import or export ? |
SlimaneAmar
force-pushed
the
applynoblocktomcat
branch
from
8cd1350 to
a893a61
Compare
SlimaneAmar
force-pushed
the
applynoblocktomcat
branch
from
a893a61 to
1b3984d
Compare
SlimaneAmar
reviewed
Oct 16, 2025
| } | ||
| } | ||
|
|
||
| public NetworkModificationResult applyModificationsBlocking(ModificationApplicationGroup modificationInfosGroup, NetworkInfos networkInfos) { |
There was a problem hiding this comment.
Move this code in a test class
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer block the tomcat thread when waiting for import or export (servlet 3.0+ AsyncContext)
Add no timeout configuration to behave like before this change
Spring forces us to adapt the tests with boilerplate code (asyncStarted() and asyncDispatch()) as per
https://docs.spring.io/spring-framework/reference/testing/mockmvc/hamcrest/async-requests.html
to mimic the servlet 3.0 redispatch
We avoid to store the return of the first perform in an MvcResult variable to avoid confusion (
The two mvc result represent the same request, inside they hold the same request/response
objects, but some other fields are different (asyncResult for example) and tests may
be unreliable if they use the first one (representing the state before the async split)
)