WIP : first commit modification #717
Open
+97
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basseche
force-pushed
the
limitsProperties_modification
branch
3 times, most recently
from
2bf48ed to
967f9e3
Compare
basseche
force-pushed
the
limitsProperties_modification
branch
2 times, most recently
from
1335bbd to
967f9e3
Compare
basseche
force-pushed
the
limitsProperties_modification
branch
from
967f9e3 to
6d45fcc
Compare
Signed-off-by: basseche <[email protected]>
basseche
force-pushed
the
limitsProperties_modification
branch
from
069ef25 to
281c14f
Compare
Mathieu-Deharbe
requested changes
Oct 31, 2025
Comment on lines
+66
to
+76
| @OneToMany(cascade = CascadeType.ALL, orphanRemoval = true) | ||
| @JoinColumn(name = "operational_limit_group_id", foreignKey = @ForeignKey(name = "operational_limit_group_modification_id_fk")) | ||
| private List<LimitsPropertyModificationEntity> limitsProperties; | ||
|
|
||
| private static List<LimitsPropertyModificationEntity> toLimitPropertyEntities(List<LimitsPropertyInfos> properties) { | ||
| List<LimitsPropertyModificationEntity> result = new ArrayList<>(); | ||
| if (!CollectionUtils.isEmpty(properties)) { | ||
| result = properties.stream().map(LimitsPropertyModificationEntity::fromLimitsPropertyInfos).toList(); | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
I think that this could be a List<LimitsPropertyEntity> (given that we only create properties and never modify, the structure is the same)
Then LimitsPropertyModificationEntity wouldn't be needed (for now anyway)
Mathieu-Deharbe
requested changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.