Skip to content

Conversation

@Mathieu-Deharbe
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe commented Dec 4, 2025

PR Summary

Only add description. It is nott needed here but is useful in the netmod copies in netmod-server

@EtienneLt
Copy link
Contributor

Could you add a test with a description on any modification

Signed-off-by: Mathieu DEHARBE <[email protected]>
@Mathieu-Deharbe
Copy link
Contributor Author

Could you add a test with a description on any modification

I added a value in the transfo creation. At least it tests that the value is initialised. Nothing else is done with this value in this lib anyway : 275c7ac

But the test coverage is still 0%. Maybe this member value doesn't register as testable code ? ModificationInfos class is not covered at all according to "test with coverage" in intellij.

Signed-off-by: Mathieu DEHARBE <[email protected]>
Copy link
Contributor

@EtienneLt EtienneLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK code OK

@sonarqubecloud
Copy link

@Mathieu-Deharbe Mathieu-Deharbe merged commit 239d61e into main Dec 12, 2025
4 checks passed
@Mathieu-Deharbe Mathieu-Deharbe deleted the add-netmod-description branch December 12, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants