Skip to content

Add context to the voltage init modification #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FranckLecuyer merged 7 commits into from
Dec 10, 2025
Merged

Add context to the voltage init modification #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b51bfca
Add rootNetworkName, nodeName and computationDate in voltage init mod…
FranckLecuyer Dec 4, 2025
ac104cf
Merge branch 'main' into add_context_info_in_voltage_init_modification
FranckLecuyer Dec 5, 2025
c1c9c8c
Fix coverage and checkstyle pb
FranckLecuyer Dec 5, 2025
b20c9a8
Merge branch 'main' into add_context_info_in_voltage_init_modification
FranckLecuyer Dec 8, 2025
fe028e1
UUID instead of name for the root network and the node in the voltage…
FranckLecuyer Dec 8, 2025
c049ae5
Revert "UUID instead of name for the root network and the node in the…
FranckLecuyer Dec 9, 2025
9c84303
Merge branch 'main' into add_context_info_in_voltage_init_modification
FranckLecuyer Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/java/org/gridsuite/modification/dto/VoltageInitModificationInfos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
import org.gridsuite.modification.modifications.AbstractModification;
import org.gridsuite.modification.modifications.VoltageInitModification;

import java.time.Instant;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* @author Franck Lecuyer <franck.lecuyer at rte-france.com>
Expand Down Expand Up @@ -48,6 +51,15 @@ public class VoltageInitModificationInfos extends ModificationInfos {
@Schema(description = "buses modifications")
private List<VoltageInitBusModificationInfos> buses;

@Schema(description = "root network name")
private String rootNetworkName;

@Schema(description = "node name")
private String nodeName;

@Schema(description = "computation date")
private Instant computationDate;

@Override
public AbstractModification toModification() {
return new VoltageInitModification(this);
Expand All @@ -57,4 +69,13 @@ public AbstractModification toModification() {
public ReportNode createSubReportNode(ReportNode reportNode) {
return reportNode.newReportNode().withMessageTemplate("network.modification.voltageInitModification").add();
}

@Override
public Map<String, String> getMapMessageValues() {
Map<String, String> mapMessageValues = new HashMap<>();
mapMessageValues.put("rootNetworkName", getRootNetworkName());
mapMessageValues.put("nodeName", getNodeName());
mapMessageValues.put("computationDate", getComputationDate() != null ? getComputationDate().toString() : null);
return mapMessageValues;
}
}
14 changes: 14 additions & 0 deletions src/test/java/org/gridsuite/modification/modifications/VoltageInitModificationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
import org.gridsuite.modification.report.NetworkModificationReportResourceBundle;
import org.gridsuite.modification.utils.NetworkCreation;
import org.junit.jupiter.api.Test;

import java.time.Instant;
import java.util.List;
import java.util.Map;
import java.util.UUID;

import static org.gridsuite.modification.utils.NetworkUtil.createGenerator;
Expand Down Expand Up @@ -199,6 +202,9 @@ protected ModificationInfos buildModification() {
.v(230.)
.angle(0.5)
.build()))
.rootNetworkName("rootNetwork1")
.nodeName("node1")
.computationDate(Instant.now())
.build();
}

Expand Down Expand Up @@ -260,6 +266,14 @@ void testVoltageInitDisconnectedCurrentSection1Section1() throws Exception {
assertEquals(1, getNetwork().getShuntCompensator("v5shunt").getSectionCount());
}

@Test
void testMapMessageValues() {
ModificationInfos modifications = buildModification();
Map<String, String> values = modifications.getMapMessageValues();
assertEquals("rootNetwork1", values.get("rootNetworkName"));
assertEquals("node1", values.get("nodeName"));
}

@Override
protected void assertAfterNetworkModificationApplication() {
assertEquals(10., getNetwork().getGenerator("idGenerator").getTargetQ(), 0.001);
Expand Down