Skip to content

Modification application with naming strategy #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2025
Merged

Modification application with naming strategy #94

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2521df
Modification application with naming strategy
etiennehomer Sep 12, 2025
6a7f9d5
use naming strategy for CreateVoltageLevelSection and CreateVoltageTo…
etiennehomer Sep 15, 2025
d03ec15
Fix DummyNamingStrategy
etiennehomer Sep 15, 2025
d485aac
Merge branch 'main' into apply_with_naming_strategy
etiennehomer Sep 15, 2025
a49b8a2
Fix test
etiennehomer Sep 16, 2025
c19224c
clean
etiennehomer Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/org/gridsuite/modification/modifications/CreateCouplingDevice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

import com.powsybl.commons.report.ReportNode;
import com.powsybl.iidm.modification.topology.CreateCouplingDeviceBuilder;
import com.powsybl.iidm.modification.topology.DefaultNamingStrategy;
import com.powsybl.iidm.modification.topology.NamingStrategy;
import com.powsybl.iidm.network.Network;
import org.gridsuite.modification.ModificationType;
import org.gridsuite.modification.dto.CreateCouplingDeviceInfos;
Expand All @@ -28,11 +30,16 @@ public CreateCouplingDevice(CreateCouplingDeviceInfos createCouplingDeviceInfos)
* @param subReportNode
*/
@Override
public void apply(Network network, ReportNode subReportNode) {
public void apply(Network network, NamingStrategy namingStrategy, ReportNode subReportNode) {
new CreateCouplingDeviceBuilder()
.withBusOrBusbarSectionId1(createCouplingDeviceInfos.getCouplingDeviceInfos().getBusbarSectionId1())
.withBusOrBusbarSectionId2(createCouplingDeviceInfos.getCouplingDeviceInfos().getBusbarSectionId2())
.build().apply(network, false, subReportNode);
.build().apply(network, namingStrategy, false, subReportNode);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove false argument !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

@Override
public void apply(Network network, ReportNode subReportNode) {
apply(network, new DefaultNamingStrategy(), subReportNode);
}

@Override
Expand Down