New fields in SA results - limit violations #197
Conversation
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
| .limitReduction(limitViolation.getLimitReduction()) | ||
| .value(limitViolation.getValue()) | ||
| .side(limitViolation.getSide()) | ||
| .loading(computeLoading(limitViolation)) |
There was a problem hiding this comment.
we don't want the same changes for N results?
There was a problem hiding this comment.
N results will be chaged on other US
| protected static Double getPatlLimit(LimitViolation limitViolation, Network network) { | ||
| String equipmentId = limitViolation.getSubjectId(); | ||
| Branch<?> branch = network.getBranch(equipmentId); | ||
| ThreeSides limitViolationSide = limitViolation.getSide(); |
There was a problem hiding this comment.
NIT: if you're dealing with branches, you could have used TwoSides
| return null; | ||
| } | ||
|
|
||
| Optional<CurrentLimits> currentLimits = limitViolationSide.name().equals(TwoSides.ONE.name()) ? branch.getCurrentLimits1() : branch.getCurrentLimits2(); |
There was a problem hiding this comment.
Can't you use :
default Optional getCurrentLimits(TwoSides side) {
of branch directly? it's a good helper method?
| return null; | ||
| } | ||
|
|
||
| Optional<CurrentLimits> currentLimits = limitViolationSide.name().equals(TwoSides.ONE.name()) ? branch.getCurrentLimits1() : branch.getCurrentLimits2(); |
There was a problem hiding this comment.
Same comment to fetch the side
There was a problem hiding this comment.
or compare directly enum instead of names at least?
| @@ -0,0 +1,60 @@ | |||
| /** | |||
| * Copyright (c) 2023, RTE (http://www.rte-france.com) | |||
| if (limitName.equals(LimitViolationUtils.PERMANENT_LIMIT_NAME)) { | ||
| return currentLimits.get().getTemporaryLimits().stream().findFirst().orElse(null); |
There was a problem hiding this comment.
NIT: temporaryLimits = currentLimits.get().getTemporaryLimits() ?
Signed-off-by: LE SAULNIER Kevin <[email protected]>
|
No description provided.