Add upcoming and current overload durations in result #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 9, 2025 10:55
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: LE SAULNIER Kevin <[email protected]>
antoinebhs
reviewed
Sep 10, 2025
| private LimitViolationType limitType; | ||
|
|
||
| private long acceptableDuration; | ||
| private Integer acceptableDuration; |
There was a problem hiding this comment.
Looks like we converted to long related sorting/filtering. I can't see why?
4f7a3f8
There was a problem hiding this comment.
After some tests, it's still working as expected, I can't find why it's ben done
src/main/resources/db/changelog/changesets/changelog_20250908T143920Z.xml
Show resolved
Hide resolved
src/main/resources/db/changelog/changesets/changelog_20250908T143920Z.xml
Show resolved
Hide resolved
src/main/java/org/gridsuite/securityanalysis/server/entities/AbstractLimitViolationEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/securityanalysis/server/entities/AbstractLimitViolationEntity.java
Outdated
Show resolved
Hide resolved
|
Looking at the recently implemented code, I think we could have used LimitViolationUtils.checkTemporaryLimits() ? It checked quickly but the logic looks similar to what we implemented? |
Signed-off-by: LE SAULNIER Kevin <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.