add new fields to security analysis results (tab N) #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klesaulnier
reviewed
Sep 16, 2025
Contributor
klesaulnier
left a comment
klesaulnier
left a comment
There was a problem hiding this comment.
I know it looks very similar to ContingencyLimitViolationEntity "toEntity", but it could be nice to add some tests for this
antoinebhs
reviewed
Sep 22, 2025
Contributor
antoinebhs
left a comment
antoinebhs
left a comment
There was a problem hiding this comment.
Can we avoid code duplication with existing test class?
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| @SpringBootTest | ||
| class PreContingencyLimitViolationTest { |
antoinebhs
reviewed
Sep 23, 2025
src/test/java/org/gridsuite/securityanalysis/server/AbstractLimitViolationTest.java
Outdated
Show resolved
Hide resolved
antoinebhs
reviewed
Sep 23, 2025
src/test/java/org/gridsuite/securityanalysis/server/ContingencyLimitViolationTest.java
Outdated
Show resolved
Hide resolved
|
klesaulnier
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.