Remove hashCode() and equals() overrides + clean result entities annotation (#66)

Signed-off-by: Etienne Homer <[email protected]>

Author: etiennehomer

src/main/java/org/gridsuite/shortcircuit/server/entities/FaultResultEntity.java

@@ -31,7 +31,7 @@ public class FaultResultEntity {
     @GeneratedValue(strategy = GenerationType.AUTO)
     private UUID faultResultUuid;
 
-    @ManyToOne(fetch = FetchType.LAZY, cascade = CascadeType.ALL)
+    @ManyToOne(fetch = FetchType.LAZY)
     @Setter
     private ShortCircuitAnalysisResultEntity result;
 
@@ -131,22 +131,6 @@ public void setFeederResults(List<FeederResultEntity> feederResults) {
         feederResults.stream().forEach(feederResultEntity -> feederResultEntity.setFaultResult(this));
     }
 
-    @Override
-    public boolean equals(Object o) {
-        if (this == o) {
-            return true;
-        }
-        if (!(o instanceof FaultResultEntity)) {
-            return false;
-        }
-        return faultResultUuid != null && faultResultUuid.equals(((FaultResultEntity) o).getFaultResultUuid());
-    }
-
-    @Override
-    public int hashCode() {
-        return getClass().hashCode();
-    }
-
     public double getPositiveMagnitude() {
         return this.getFortescueCurrent() != null ? this.getFortescueCurrent().getPositiveMagnitude() : Double.NaN;
     }

src/main/java/org/gridsuite/shortcircuit/server/entities/FeederResultEntity.java

@@ -28,10 +28,7 @@ public class FeederResultEntity {
     @GeneratedValue(strategy = GenerationType.AUTO)
     private UUID feederResultUuid;
 
-    @ManyToOne(
-            cascade = CascadeType.ALL,
-            fetch = FetchType.LAZY
-    )
+    @ManyToOne(fetch = FetchType.LAZY)
     @JoinColumn(name = "fault_result_entity_fault_result_uuid")
     private FaultResultEntity faultResult;
 

src/main/java/org/gridsuite/shortcircuit/server/entities/ShortCircuitAnalysisResultEntity.java

@@ -30,6 +30,12 @@ public class ShortCircuitAnalysisResultEntity {
     @Column
     private ZonedDateTime writeTimeStamp;
 
+    /*
+    Bidirectional relation is not needed here and is done for performance
+    https://vladmihalcea.com/the-best-way-to-map-a-onetomany-association-with-jpa-and-hibernate/
+    equals() and hashCode() methods are not overrided as the article above recommands it because we use a Set of FaultResultEntity
+    and having a constant hashCode() causes performance issues.
+     */
     @OneToMany(mappedBy = "result", cascade = CascadeType.ALL, orphanRemoval = true)
     @Setter
     private Set<FaultResultEntity> faultResults;

src/test/java/org/gridsuite/shortcircuit/server/repositories/FaultResultRepositoryTest.java

@@ -99,7 +99,7 @@ void tearDown() {
     void faultResultFilterTest(ShortCircuitAnalysisResultEntity resultEntity, List<ResourceFilter> resourceFilters, List<FaultResultEntity> faultList) {
         Page<FaultResultEntity> faultPage = shortCircuitAnalysisResultRepository.findFaultResultsPage(resultEntity, resourceFilters, Pageable.unpaged(), FaultResultsMode.BASIC);
         assertThat(faultPage.getContent()).extracting("fault.id").describedAs("Check if the IDs of the fault page are correct")
-            .containsExactlyElementsOf(faultList.stream().map(faultResultEntity -> faultResultEntity.getFault().getId()).toList());
+            .containsExactlyInAnyOrderElementsOf(faultList.stream().map(faultResultEntity -> faultResultEntity.getFault().getId()).toList());
     }
 
     private Stream<Arguments> provideOrEqualsNestedFieldsFilters() {