Skip to content

Conversation

achour94
Copy link
Collaborator

No description provided.

@achour94 achour94 self-assigned this Jun 16, 2025
achour94 added 2 commits June 17, 2025 16:17
…formulas

# Conflicts:
#	src/main/resources/db/changelog/db.changelog-master.yaml
Copy link

@achour94 achour94 requested a review from dbraquart June 18, 2025 11:52
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: update sql needed
tests: not done

UPDATE spreadsheet_column
SET formula = '(maxQAtNominalV / maximumSectionCount) * sectionCount'
WHERE column_id = 'switchedOnQAtNominalV'
AND formula = 'maxQAtNominalV / maximumSectionCount';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have the previous changlog that converts switchedOnQAtNominalV into maxQAtNominalV / maximumSectionCount :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

@achour94 achour94 requested a review from dbraquart June 18, 2025 13:47
UPDATE spreadsheet_column
SET formula = '(maxQAtNominalV / maximumSectionCount) * sectionCount'
WHERE column_id = 'switchedOnQAtNominalV'
AND formula = 'maxQAtNominalV / maximumSectionCount';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have the previous changlog that converts switchedOnQAtNominalV into maxQAtNominalV / maximumSectionCount :)

Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests & migrations: ok

@achour94 achour94 merged commit 85e1bd2 into main Jun 18, 2025
4 checks passed
@achour94 achour94 deleted the fix-switchOn-columns-formulas branch June 18, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants