-
Notifications
You must be signed in to change notification settings - Fork 0
Correct formulas for switchedOnQAtNominalV and switchedOnSusceptance #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in spreadsheet configuration Signed-off-by: achour94 <[email protected]>
…formulas # Conflicts: # src/main/resources/db/changelog/db.changelog-master.yaml
…spreadsheet configuration Signed-off-by: achour94 <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: update sql needed
tests: not done
UPDATE spreadsheet_column | ||
SET formula = '(maxQAtNominalV / maximumSectionCount) * sectionCount' | ||
WHERE column_id = 'switchedOnQAtNominalV' | ||
AND formula = 'maxQAtNominalV / maximumSectionCount'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still have the previous changlog that converts switchedOnQAtNominalV into maxQAtNominalV / maximumSectionCount :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
UPDATE spreadsheet_column | ||
SET formula = '(maxQAtNominalV / maximumSectionCount) * sectionCount' | ||
WHERE column_id = 'switchedOnQAtNominalV' | ||
AND formula = 'maxQAtNominalV / maximumSectionCount'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still have the previous changlog that converts switchedOnQAtNominalV into maxQAtNominalV / maximumSectionCount :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: ok
tests & migrations: ok
No description provided.