Skip to content

Use notifications to manage parameter changes #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Use notifications to manage parameter changes #84

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8aa6e35
Add paramsName to the notification header.
AAJELLAL Sep 11, 2024
1669f99
Merge branch 'main' of https://github.com/gridsuite/study-notificatio…
AAJELLAL Sep 11, 2024
ed5d60f
Change the header params name.
AAJELLAL Sep 18, 2024
58b73b1
Merge branch 'main' of https://github.com/gridsuite/study-notificatio…
AAJELLAL Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/org/gridsuite/study/notification/server/NotificationWebSocketHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ public class NotificationWebSocketHandler implements WebSocketHandler {
static final String USER_TAG = "user";

private final ObjectMapper jacksonObjectMapper;
public static final String HEADER_PARAMS_NAME = "paramsName";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why public ?
move it just near the other HEADER_*** constants definition maybe ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.


private final int heartbeatInterval;

Expand Down Expand Up @@ -147,6 +148,7 @@ private static Map<String, Object> toResultHeader(Map<String, Object> messageHea
passHeader(messageHeader, resHeader, HEADER_USER_ID); // to filter the display of error messages in the front end
passHeader(messageHeader, resHeader, HEADER_REFERENCE_NODE_UUID);
passHeader(messageHeader, resHeader, HEADER_INDEXATION_STATUS);
passHeader(messageHeader, resHeader, HEADER_PARAMS_NAME);

return resHeader;
}
Expand Down
Loading