-
Notifications
You must be signed in to change notification settings - Fork 2
implement asynch export #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghazwarhili
wants to merge
4
commits into
main
Choose a base branch
from
implement-asynch-export
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,7 +104,39 @@ public String getExportFormats() { | |
return restTemplate.exchange(networkConversionServerBaseUri + path, HttpMethod.GET, null, typeRef).getBody(); | ||
} | ||
|
||
public void exportNetwork(UUID networkUuid, String variantId, String format, String parametersJson, String fileName, HttpServletResponse exportNetworkResponse) { | ||
public void downloadExportNetworkFile(UUID exportUuid, HttpServletResponse exportNetworkResponse) { | ||
|
||
try (ServletOutputStream outputStream = exportNetworkResponse.getOutputStream()) { | ||
var uriComponentsBuilder = UriComponentsBuilder.fromPath(DELIMITER + NETWORK_CONVERSION_API_VERSION + "/download/{exportUuid}"); | ||
String path = uriComponentsBuilder.buildAndExpand(exportUuid).toUriString(); | ||
|
||
restTemplate.execute( | ||
networkConversionServerBaseUri + path, | ||
HttpMethod.GET, | ||
request -> { }, | ||
networkConversionServerResponse -> { | ||
String fileNameFromResponse = networkConversionServerResponse.getHeaders().getContentDisposition().getFilename(); | ||
long contentLength = networkConversionServerResponse.getHeaders().getContentLength(); | ||
exportNetworkResponse.setHeader(HttpHeaders.CONTENT_DISPOSITION, ContentDisposition.builder("attachment").filename(fileNameFromResponse).build().toString()); | ||
exportNetworkResponse.setHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_OCTET_STREAM.toString()); | ||
if (contentLength != -1) { | ||
exportNetworkResponse.setContentLengthLong(contentLength); | ||
} | ||
exportNetworkResponse.setStatus(HttpStatus.OK.value()); | ||
StreamUtils.copy(networkConversionServerResponse.getBody(), outputStream); | ||
outputStream.flush(); | ||
return null; | ||
} | ||
); | ||
} catch (HttpStatusCodeException e) { | ||
throw handleHttpError(e, NETWORK_EXPORT_FAILED); | ||
} catch (IOException e) { | ||
throw new StudyException(NETWORK_EXPORT_FAILED, e.getMessage()); | ||
} | ||
} | ||
|
||
public void exportNetwork(UUID studyUuid, UUID nodeUuid, UUID rootNetworkUuid, UUID networkUuid, String variantId, String format, | ||
String parametersJson, String fileName, String userId, HttpServletResponse exportNetworkResponse) { | ||
|
||
try (ServletOutputStream outputStream = exportNetworkResponse.getOutputStream()) { | ||
var uriComponentsBuilder = UriComponentsBuilder.fromPath(DELIMITER + NETWORK_CONVERSION_API_VERSION | ||
|
@@ -116,31 +148,27 @@ public void exportNetwork(UUID networkUuid, String variantId, String format, Str | |
if (!StringUtils.isEmpty(fileName)) { | ||
uriComponentsBuilder.queryParam("fileName", fileName); | ||
} | ||
|
||
String receiver = studyUuid + "|" + nodeUuid + "|" + rootNetworkUuid + "|" + userId; | ||
uriComponentsBuilder.queryParam("receiver", receiver); | ||
String path = uriComponentsBuilder.buildAndExpand(networkUuid, format) | ||
.toUriString(); | ||
|
||
restTemplate.execute( | ||
networkConversionServerBaseUri + path, | ||
HttpMethod.POST, | ||
request -> { | ||
request.getHeaders().setContentType(MediaType.APPLICATION_JSON); | ||
if (parametersJson != null && !parametersJson.isEmpty()) { | ||
StreamUtils.copy(parametersJson, StandardCharsets.UTF_8, request.getBody()); | ||
} | ||
}, | ||
networkConversionServerResponse -> { | ||
String fileNameFromResponse = networkConversionServerResponse.getHeaders().getContentDisposition().getFilename(); | ||
long contentLength = networkConversionServerResponse.getHeaders().getContentLength(); | ||
exportNetworkResponse.setHeader(HttpHeaders.CONTENT_DISPOSITION, ContentDisposition.builder("attachment").filename(fileNameFromResponse, StandardCharsets.UTF_8).build().toString()); | ||
exportNetworkResponse.setHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_OCTET_STREAM.toString()); | ||
if (contentLength != -1) { | ||
exportNetworkResponse.setContentLengthLong(contentLength); | ||
networkConversionServerBaseUri + path, | ||
HttpMethod.POST, | ||
request -> { | ||
request.getHeaders().setContentType(MediaType.APPLICATION_JSON); | ||
if (parametersJson != null && !parametersJson.isEmpty()) { | ||
StreamUtils.copy(parametersJson, StandardCharsets.UTF_8, request.getBody()); | ||
} | ||
}, | ||
networkConversionServerResponse -> { | ||
exportNetworkResponse.setStatus(HttpStatus.ACCEPTED.value()); | ||
exportNetworkResponse.setContentType(MediaType.APPLICATION_JSON_VALUE); | ||
String responseJson = "{\"message\":\"Export started, you will receive a notification when ready\"}"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is useful when return a non translated message? I dont see it is used in the front If you really need a returned message, using objectMapper.createObjectNode() to build a typed object instead of a json string directly |
||
StreamUtils.copy(responseJson, StandardCharsets.UTF_8, outputStream); | ||
return null; | ||
} | ||
exportNetworkResponse.setStatus(HttpStatus.OK.value()); | ||
StreamUtils.copy(networkConversionServerResponse.getBody(), outputStream); | ||
return null; | ||
} | ||
); | ||
} catch (HttpStatusCodeException e) { | ||
throw handleHttpError(e, NETWORK_EXPORT_FAILED); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conversion server using 'error' key for error message, idem in the front