Fix building shared libraries for Windows environments#224
Open
synthetic-borealis wants to merge 4 commits intogrimfang4:masterfrom
Open
Fix building shared libraries for Windows environments#224synthetic-borealis wants to merge 4 commits intogrimfang4:masterfrom
synthetic-borealis wants to merge 4 commits intogrimfang4:masterfrom
Conversation
|
The .dll and .a files are still not being properly created by Mingw. The only way to obtain .dll and .a files from a Mingw compilation currently in my attempts is through MSYS2. I have done so here. If you require 0.12 librairies for Windows, use this build it should work: https://github.com/l-t-m-f/SDL2_gpu-0.12.0-mingw64.zip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes some changes to
src/CMakeLists.txtthat ensure shared libraries build and install correctly on Windows environments.The changes I made are:
set(CMAKE_SHARED_LIBRARY_PREFIX )- Prevent DLL files from having a prefix added to their name (i.e. libSDL_gpu.dll when it should be SDL_gpu.dll) when building with MinGW.target_compile_definitions(SDL_gpu_shared PUBLIC DLL_EXPORT)- Ensure DLL files export symbols and import libraries are generated when compiled with Visual Studio/Microsoft C++.install(TARGETS SDL_gpu_shared EXPORT SDL_gpu-targets LIBRARY DESTINATION lib)- Install DLL files in thebindirectory and *.lib/*.a files in thelibdirectory.