Fixing rendering of primitives#242
Open
avahe-kellenberger wants to merge 3 commits intogrimfang4:masterfrom
Open
Fixing rendering of primitives#242avahe-kellenberger wants to merge 3 commits intogrimfang4:masterfrom
avahe-kellenberger wants to merge 3 commits intogrimfang4:masterfrom
Conversation
The function now uses an "inner-stroke" instead of trying to center the lines of the rectangle onto its outer pixel coordinates.
SplinterGU
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve issues addressed in #220
If any of these behavioral changes are unwanted, maybe we can introduce a way to allow the users to decide on the behavior. E.g. enums/booleans, new functions, etc.
Here's an illustration of the changes made to GPU_Rectangle: