One Dimensional Freely Propagating Flame Physics and Example, as well as b#591
Open
klbudzin wants to merge 44 commits intogrinsfem:masterfrom
Open
One Dimensional Freely Propagating Flame Physics and Example, as well as b#591klbudzin wants to merge 44 commits intogrinsfem:masterfrom
klbudzin wants to merge 44 commits intogrinsfem:masterfrom
Conversation
… not added in the makefile yet
…eed to adjust how i construct the chemistry as it is done in a deprecated manner atm.
…yCondition/MassFlux
… a certain reaction type, still needs more automation to just read everything from the xml, and require less input between checks
…o rethink how Im calculating them, might be best to return all as a vector, since you will usually use them all when needed, and cantera calculates the vector every call anyways
…stead of individually
…ere I wasnt pulling in the values from the side of the element
…ulating a postprocessed value
…nge the name, this fixes that
…changed later to have it be inputted
…e reading right, and be able to be able to read during runtime if you were inputting the wrong species in the input file
… temperature is evaluated and returned.
…t does not matter where it is evaluated at
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request for the one dimensional freely propagating flame physics I have been working on for my masters. Here a new od_premixed_flame physics class is added as well as two new qoi's, the flame_speed, and adiabatic_flame_temperature( which currently just calculates the temperature at a set point in the domain). An example was for a one dimensional methane flame using the gri30 mechanism at stoichiometric conditions is also added.
On top of this is a bug fix for the side_time_derivative method in the multi_physics class where the side_time_derivative method of the implemented physics was not being called correctly. Also some clipping methods were added to cantera to clip negative temperatures and densities.