Conversation
|
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adds a new Storybook story for SelectMultiple in the Design System and introduces a reusable placeholder argType for consistent controls.
Changes:
- Added
placeholderArgin shared Storybook arg utilities - Added
SelectMultipleStorybook story with common controls and default args
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| shared/aries-core/src/stories/utils/commonArgs.tsx | Adds a reusable placeholder argType for Storybook controls |
| shared/aries-core/src/stories/components/SelectMultiple.stories.tsx | Introduces a new Storybook story for SelectMultiple with configurable props |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx
Outdated
Show resolved
Hide resolved
| a11yTitle: 'Multiple selection', | ||
| defaultValue: undefined, | ||
| disabled: false, | ||
| open: false, |
There was a problem hiding this comment.
Setting open: false in args will typically force the component to remain closed (controlled prop), preventing users from interacting with the story to open the dropdown. Consider removing open from args (and possibly from argTypes) unless this story is specifically meant to demonstrate the controlled open behavior.
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx
Outdated
Show resolved
Hide resolved
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx
Outdated
Show resolved
Hide resolved
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx
Outdated
Show resolved
Hide resolved
…d-selectmultiple-story
| '4XL', | ||
| ], | ||
| placeholder: 'Select multiple options', | ||
| searchPlaceholder: 'Search options', |
There was a problem hiding this comment.
I did not see where the searchPlaceholder is showing up on the UI.
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx
Outdated
Show resolved
Hide resolved
…s.tsx Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>

Deploy Preview
What does this PR do?
What are the relevant issues?
related to #5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?