Skip to content

DS storybook - selectmultiple story#5788

Merged
jcfilben merged 7 commits intomasterfrom
add-selectmultiple-story
Feb 19, 2026
Merged

DS storybook - selectmultiple story#5788
jcfilben merged 7 commits intomasterfrom
add-selectmultiple-story

Conversation

@britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Feb 9, 2026

Deploy Preview

What does this PR do?

What are the relevant issues?

related to #5710

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2026

⚠️ No Changeset found

Latest commit: 8c02748

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 9, 2026

Deploy Preview for hpe-theme-preview ready!

Name Link
🔨 Latest commit 8c02748
🔍 Latest deploy log https://app.netlify.com/projects/hpe-theme-preview/deploys/69977e8915edd80008d6daad
😎 Deploy Preview https://deploy-preview-5788--hpe-theme-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 9, 2026

Deploy Preview for hpe-design-icons-grommet ready!

Name Link
🔨 Latest commit 8c02748
🔍 Latest deploy log https://app.netlify.com/projects/hpe-design-icons-grommet/deploys/69977e894db2de000885393b
😎 Deploy Preview https://deploy-preview-5788--hpe-design-icons-grommet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@britt6612 britt6612 requested a review from Copilot February 9, 2026 16:41
@netlify
Copy link

netlify bot commented Feb 9, 2026

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 8c02748
🔍 Latest deploy log https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/69977e895cb4560008f3efb7
😎 Deploy Preview https://deploy-preview-5788--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Storybook story for SelectMultiple in the Design System and introduces a reusable placeholder argType for consistent controls.

Changes:

  • Added placeholderArg in shared Storybook arg utilities
  • Added SelectMultiple Storybook story with common controls and default args

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
shared/aries-core/src/stories/utils/commonArgs.tsx Adds a reusable placeholder argType for Storybook controls
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx Introduces a new Storybook story for SelectMultiple with configurable props

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

a11yTitle: 'Multiple selection',
defaultValue: undefined,
disabled: false,
open: false,
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting open: false in args will typically force the component to remain closed (controlled prop), preventing users from interacting with the story to open the dropdown. Consider removing open from args (and possibly from argTypes) unless this story is specifically meant to demonstrate the controlled open behavior.

Copilot uses AI. Check for mistakes.
@britt6612 britt6612 requested a review from jcfilben February 11, 2026 16:19
@britt6612 britt6612 requested a review from jcfilben February 17, 2026 20:07
@Sulaymon333 Sulaymon333 self-requested a review February 19, 2026 15:37
'4XL',
],
placeholder: 'Select multiple options',
searchPlaceholder: 'Search options',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see where the searchPlaceholder is showing up on the UI.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2026-02-19 at 2 20 48 PM

you have to activate the search to see it

…s.tsx

Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
@jcfilben jcfilben dismissed Sulaymon333’s stale review February 19, 2026 22:36

Changes requested unnecessary

@jcfilben jcfilben merged commit 7209806 into master Feb 19, 2026
19 of 21 checks passed
@jcfilben jcfilben deleted the add-selectmultiple-story branch February 19, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants