DS storybook - add RangeInput story#5789
Conversation
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jcfilben
left a comment
jcfilben
left a comment
There was a problem hiding this comment.
Looks like the deploy preview isn't working
shared/aries-core/src/stories/components/RangeInput.stories.tsx
Outdated
Show resolved
Hide resolved
jcfilben
left a comment
jcfilben
left a comment
There was a problem hiding this comment.
Don't need to fix this right now, more of a polishing note for later
The RangeInput is so close to the top edge of the container that the focus indicator gets cut off.
When we explore centering stories within the canvas we should consider this one as a candidate.
| min: 0, | ||
| onChange: undefined, | ||
| step: 1, | ||
| value: 50, |
There was a problem hiding this comment.
When I try to set the value it doesn't work
There was a problem hiding this comment.
its kinda finicky you have to refresh the page to see the change
There was a problem hiding this comment.
I just removed since it was being finicky
…-storybook-add-rangeinput-story
3 participants
Deploy Preview
What does this PR do?
add RangeInput to storybook
What are the relevant issues?
related to #5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?