Conversation
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jcfilben
left a comment
jcfilben
left a comment
There was a problem hiding this comment.
Getting a white space around the story
jcfilben
left a comment
jcfilben
left a comment
There was a problem hiding this comment.
Still seeing the white space around the story as noted above
| import { Data, DataSearch, DataSort, DataSummary, Toolbar } from 'grommet'; | ||
|
|
||
| // Mock data for the toolbar example | ||
| const mockApplications = [ |
There was a problem hiding this comment.
should we remove unused data? Or is there plan to pass it down to <Data data={DATA}> to ensure data sort by drop down is not empty like we have on community storybook for data filters?
community storybook
core storybook
There was a problem hiding this comment.
I added Data as well as DataTable as we decided yesterday in our dev chat
| render: args => { | ||
| return ( | ||
| <Toolbar {...args}> | ||
| <DataSearch /> | ||
| <DataSort drop /> | ||
| </Toolbar> | ||
| ); | ||
| }, | ||
| }; |
There was a problem hiding this comment.
| render: args => { | |
| return ( | |
| <Toolbar {...args}> | |
| <DataSearch /> | |
| <DataSort drop /> | |
| </Toolbar> | |
| ); | |
| }, | |
| }; | |
| render: args => ( | |
| <Toolbar {...args}> | |
| <DataSearch /> | |
| <DataSort drop /> | |
| </Toolbar> | |
| ), | |
| args: {}, | |
| } satisfies Story; |
| parameters: { | ||
| layout: 'fullscreen', | ||
| }, |
There was a problem hiding this comment.
| parameters: { | |
| layout: 'fullscreen', | |
| }, | |
| argTypes: {}, |
|
It looks like some of the CI workflows are failing 10:15:39 PM: Error message
10:15:39 PM: Deploy did not succeed: Deploy directory 'apps/docs/out' does not exist |
those are from aries-site so it wont matter for this PR. |
3 participants
Deploy Preview
What does this PR do?
adds
toolbarstoryWhat are the relevant issues?
related to #5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?