Skip to content

DS Storybook - Add DataFilters story#5814

Merged
jcfilben merged 7 commits intomasterfrom
sb-datafilters
Feb 20, 2026
Merged

DS Storybook - Add DataFilters story#5814
jcfilben merged 7 commits intomasterfrom
sb-datafilters

Conversation

@jcfilben
Copy link
Collaborator

@jcfilben jcfilben commented Feb 12, 2026

https://deploy-preview-5814--unrivaled-bublanina-3a9bae.netlify.app/?path=/story/components-datafilters--default

What does this PR do?

Add story for DataFilters

What are the relevant issues?

#5710

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2026

⚠️ No Changeset found

Latest commit: 38a6349

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 12, 2026

Deploy Preview for hpe-theme-preview ready!

Name Link
🔨 Latest commit 38a6349
🔍 Latest deploy log https://app.netlify.com/projects/hpe-theme-preview/deploys/69973f648b11870008dd835a
😎 Deploy Preview https://deploy-preview-5814--hpe-theme-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 12, 2026

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 38a6349
🔍 Latest deploy log https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/69973f645a9de30008e2c108
😎 Deploy Preview https://deploy-preview-5814--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 12, 2026

Deploy Preview for hpe-design-icons-grommet ready!

Name Link
🔨 Latest commit 38a6349
🔍 Latest deploy log https://app.netlify.com/projects/hpe-design-icons-grommet/deploys/69973f648b11870008dd835e
😎 Deploy Preview https://deploy-preview-5814--hpe-design-icons-grommet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jcfilben
Copy link
Collaborator Author

Don't merge yet, need to add datatable baed on yesterday's dev discussion

@jcfilben
Copy link
Collaborator Author

Update example to include Datatable

@jcfilben jcfilben requested a review from britt6612 February 19, 2026 16:51
@Sulaymon333
Copy link
Collaborator

I notice the closed icon won't close the drop when it is active, but clicking out of the drop close it and it closes when in layer mode as well. We did not have the icon on the community strorybook example
image

community storybook example
image

@jcfilben
Copy link
Collaborator Author

@Sulaymon333 I'm not seeing the close icon when I'm in the 'drop' mode of the story
Screenshot 2026-02-19 at 1 25 53 PM

@jcfilben
Copy link
Collaborator Author

Do you have layer set to true at the same time as drop is set to true? If so only one can be true the other should be false

@Sulaymon333
Copy link
Collaborator

Yes, I had both of them on. Should we add mutually exclusive check for both layer and drop props in the story?

image

@Sulaymon333
Copy link
Collaborator

Sulaymon333 commented Feb 20, 2026

Should we consider adding padding to the bounding box so that the badge number can show?

image

@britt6612
Copy link
Collaborator

Should we consider adding padding to the bounding box so that the badge number can show?

image

@Sulaymon333 we have a follow on issue for all the stories for spacing
#5760 so we can tackle that next.

@jcfilben
Copy link
Collaborator Author

Should we add mutually exclusive check for both layer and drop props in the story?

i can see this being useful, for now I'm okay with moving forward as is for MVP

@jcfilben jcfilben merged commit be1d4c2 into master Feb 20, 2026
19 of 21 checks passed
@jcfilben jcfilben deleted the sb-datafilters branch February 20, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants