DS Storybook - Add DataTableColumns story#5815
Conversation
|
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| const meta = { | ||
| title: 'Components/DataTableColumns', | ||
| component: DataTableColumns, | ||
| argTypes: { |
There was a problem hiding this comment.
Should we include options?
| </Data> | ||
| ), | ||
| args: { | ||
| drop: true, |
There was a problem hiding this comment.
The drop view is a bit odd since it tried to stretch across the screen. Wondering if we set this to false by default
There was a problem hiding this comment.
Adding <Toolbar/> solves this. Should we go with this direction?
There was a problem hiding this comment.
we could.. Im open to either was just trying to keep the stories lean
There was a problem hiding this comment.
Agree with keeping things lean for MVP, we can revisit later if needed
…d-datatablecolumns-story
3 participants
Deploy Preview
What does this PR do?
adds DataTableColumns story
What are the relevant issues?
#5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?