DS Storybook - Add DataSummary story#5818
Conversation
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
britt6612
changed the title
| title: 'Components/DataSummary', | ||
| component: DataSummary, | ||
| argTypes: { | ||
| messages: { |
There was a problem hiding this comment.
I don't think we want design system users changing the messages (expect for internationalization purposes which should be done at the Grommet level)
There was a problem hiding this comment.
The main customization is typically "items" I'd say. I think in many cases it reads better to use the proper noun for what's in the data (e.g. devices).
There was a problem hiding this comment.
A quick clarification, is there any drawback for non design system users to customizing message at <DataSummary/> level, if any should we document it on the grommet doc site?
There was a problem hiding this comment.
I dont think there is any drawback I think its more of a one off if someone needs. We just decided to leave it off the story. Majority of users will leverage the grommet messages however if they need different wording for one specific example they will use the messages at the DataSummary level.
4 participants
Deploy Preview
What does this PR do?
adds dataSummary story
What are the relevant issues?
#5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?