Conversation
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| const meta = { | ||
| title: 'Components/Data', | ||
| component: Data, | ||
| argTypes: { |
There was a problem hiding this comment.
Should we expose the data, defaultView, properties, view, andviews props? Feels like these are prop people would want to play around with to understand the component
Sulaymon333
left a comment
Sulaymon333
left a comment
There was a problem hiding this comment.
I added suggestions to fix the typing issues.
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
| direction: 'desc', | ||
| }, | ||
| }, | ||
| filteredTotal: 8, |
There was a problem hiding this comment.
This prop doesn't feel relevant for storybook. It's used when data comes from an api.
| }, | ||
| }, | ||
| filteredTotal: 8, | ||
| id: 'data_example', |
There was a problem hiding this comment.
Feel like we don't need id for storybook
| description: 'The set of predefined views of the data.', | ||
| table: { | ||
| type: { summary: 'array' }, | ||
| defaultValue: { |
There was a problem hiding this comment.
Why do we define defaultValue and then also define args in the story?
|
Few comments
|
@Sulaymon333 good points and addressed |
Sulaymon333
left a comment
Sulaymon333
left a comment
There was a problem hiding this comment.
I left few comments
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
Co-authored-by: Sulaymon333 <tjsulaymon@gmail.com>
… into add-data-story
3 participants
Deploy Preview
What does this PR do?
adds Data story
What are the relevant issues?
#5710
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?