Skip to content

DS Storybook - Add DataTable story#5838

Merged
jcfilben merged 5 commits intomasterfrom
add-datatable-story
Feb 23, 2026
Merged

DS Storybook - Add DataTable story#5838
jcfilben merged 5 commits intomasterfrom
add-datatable-story

Conversation

@britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Feb 20, 2026

Deploy Preview

What does this PR do?

adds datatable example

What are the relevant issues?

related to #5710

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026

⚠️ No Changeset found

Latest commit: ab2f363

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for hpe-theme-preview ready!

Name Link
🔨 Latest commit ab2f363
🔍 Latest deploy log https://app.netlify.com/projects/hpe-theme-preview/deploys/699c9aa7c66ee80008686a4f
😎 Deploy Preview https://deploy-preview-5838--hpe-theme-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit ab2f363
🔍 Latest deploy log https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/699c9aa7fad8ca0008599c8b
😎 Deploy Preview https://deploy-preview-5838--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@britt6612 britt6612 marked this pull request as draft February 20, 2026 20:30
@netlify
Copy link

netlify bot commented Feb 20, 2026

Deploy Preview for hpe-design-icons-grommet ready!

Name Link
🔨 Latest commit ab2f363
🔍 Latest deploy log https://app.netlify.com/projects/hpe-design-icons-grommet/deploys/699c9aa73f17c00008c83f72
😎 Deploy Preview https://deploy-preview-5838--hpe-design-icons-grommet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jcfilben jcfilben marked this pull request as ready for review February 23, 2026 16:57
@jcfilben
Copy link
Collaborator

Pushed up some cleanup changes, marking as ready for review

Copy link
Collaborator

@seanhillweb seanhillweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed comment.

@Sulaymon333
Copy link
Collaborator

Should we consider adding % to the "Complete" column? So that the table is more readable and it is in line with what we would want to recommend as guidance
image

There is a similar example on DS site on DataTable page
image

@jcfilben jcfilben merged commit 0cd21dc into master Feb 23, 2026
19 of 21 checks passed
@jcfilben jcfilben deleted the add-datatable-story branch February 23, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants