Conversation
|
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the Layer component documentation page by introducing a new “Use cases” section near the top of the page.
Changes:
- Reformatted the
layoutsimport block for readability/formatting consistency. - Replaced the previous “When to use” content with a new “Use cases” section containing multiple new subsections (currently placeholder text).
- Minor formatting tweak near the Accessibility section (quote style + spacing).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Use cases | ||
|
|
||
| ### Confirming next steps | ||
|
|
||
| [Placeholder for confirming next steps example] | ||
|
|
||
| ### Confirming destructive deletion | ||
|
|
||
| [Placeholder for confirming destructive deletion example] |
There was a problem hiding this comment.
The new "Use cases" section currently renders multiple bracketed placeholder lines (e.g. "[Placeholder for …]") and also removes the prior introductory guidance about when Layers should be used. This will ship unfinished content to the docs; either replace these placeholders with real guidance/examples, or hide them (e.g. MDX comments) and keep a short introductory paragraph explaining intended usage until examples are ready.
|
|
||
| [Placeholder for filtering data example] | ||
|
|
||
| ### Completing a multi‑step process |
There was a problem hiding this comment.
The heading "Completing a multi‑step process" uses a non-standard hyphen character (U+2011), while the placeholder text below uses a regular hyphen ("multi-step"). Consider using a regular '-' in the heading as well to avoid odd anchor/slug generation and keep wording consistent.
| ### Completing a multi‑step process | |
| ### Completing a multi-step process |
|
|
||
| ### Announcing layer open and close | ||
|
|
||
| It is critical that users of assisstive technologies are informed when a layer opens and closes. The approach to implementation differs. depending on if a layer is [modal](#modal-layers) or [non-modal](#non-modal-layers). |
There was a problem hiding this comment.
Typo: "assisstive" should be "assistive".
| The following should cause an actionable layer to close: | ||
|
|
||
| 1. Clicking the [close icon](/foundation/icons#ui-actions) button in the layer's header. | ||
| - Note: Actionable center layers should not include a close button in the layer's header. Center layers generally present confirmations, therefor the user should intentionally choose between accepting or cancelling the layer's action prompt. |
There was a problem hiding this comment.
Typo: "therefor" should be "therefore".
|
|
||
| ### Announcing layer open and close | ||
|
|
||
| It is critical that users of assisstive technologies are informed when a layer opens and closes. The approach to implementation differs. depending on if a layer is [modal](#modal-layers) or [non-modal](#non-modal-layers). |
There was a problem hiding this comment.
Grammar/punctuation: "The approach to implementation differs. depending on if…" should be a single sentence (e.g., "differs depending on whether…").
Sulaymon333
changed the title
Deploy Preview
What does this PR do?
What are the relevant issues?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?