Skip to content

[Build-Netlify] update netlify.toml file to build feature branch PRs #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sulaymon333 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Build-Netlify] update netlify.toml file to build feature branch PRs #5860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,14 @@
[build.environment]
YARN_FLAGS = "--update-checksums"
Copy link
Collaborator Author

@Sulaymon333 Sulaymon333 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this line since we have moved away from yarn and now run pnpm as our package manager

[build]
ignore = '''
if [ "$CONTEXT" = "deploy-preview" ]; then
if [ "$BRANCH" = "master" ]; then
exit 1
fi

case "$BRANCH" in
wip-*) exit 1 ;;
*) exit 0 ;;
esac
Comment on lines +8 to +11
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic appears to be inverted from what the PR description states. According to the PR description, this change should "add deploy preview for feature branches starting with wip-". However, the current logic skips builds (exit 1) for branches matching "wip-" pattern, which means deploy previews will NOT be generated for these branches. If the intent is to enable deploy previews for wip-* branches, the case statement should be: wip-*) exit 0 ;; *) exit 1 ;; instead.

Copilot uses AI. Check for mistakes.
fi
exit 1
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final exit 1 at line 13 will execute for all contexts other than deploy-preview, which means builds will be skipped for production deployments and branch deployments. If the intent is to only control deploy-preview builds and allow other build contexts to proceed normally, this line should be exit 0 instead, or the entire if block should not have a fallthrough exit statement.

Suggested change
exit 1
exit 0

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@Sulaymon333 Sulaymon333 Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is wrong based on Netlify documentation on ignore exit code

'''
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous build.environment configuration with YARN_FLAGS has been completely removed without explanation. If this was intentional, consider documenting why this configuration is no longer needed. If the YARN_FLAGS setting is still required, it should be preserved alongside the new ignore configuration.

Suggested change
'''
'''
# Note: A previous [build.environment] configuration with YARN_FLAGS was intentionally removed.
# The build no longer relies on custom Yarn flags, so the YARN_FLAGS setting is not required here.

Copilot uses AI. Check for mistakes.