Skip to content

DS storybook - Change a11yTitle to aria-label#5863

Merged
jcfilben merged 4 commits intomasterfrom
sb-aria
Mar 5, 2026
Merged

DS storybook - Change a11yTitle to aria-label#5863
jcfilben merged 4 commits intomasterfrom
sb-aria

Conversation

@jcfilben
Copy link
Collaborator

@jcfilben jcfilben commented Feb 27, 2026

https://deploy-preview-5863--unrivaled-bublanina-3a9bae.netlify.app/

What does this PR do?

Change DS storybook stories to use aria-label instead of a11yTitle to align with the native html property. Also added react imports to stories that were missing them and did a bit of cleanup.

What are the relevant issues?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@netlify
Copy link

netlify bot commented Feb 27, 2026

Deploy Preview for hpe-theme-preview ready!

Name Link
🔨 Latest commit 3daab9a
🔍 Latest deploy log https://app.netlify.com/projects/hpe-theme-preview/deploys/69a9e2022051f100083344c8
😎 Deploy Preview https://deploy-preview-5863--hpe-theme-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jcfilben jcfilben requested a review from Copilot February 27, 2026 17:50
@netlify
Copy link

netlify bot commented Feb 27, 2026

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 3daab9a
🔍 Latest deploy log https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/69a9e202593dd00008536a67
😎 Deploy Preview https://deploy-preview-5863--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026

⚠️ No Changeset found

Latest commit: 3daab9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 27, 2026

Deploy Preview for hpe-design-icons-grommet ready!

Name Link
🔨 Latest commit 3daab9a
🔍 Latest deploy log https://app.netlify.com/projects/hpe-design-icons-grommet/deploys/69a9e202647c070008272f91
😎 Deploy Preview https://deploy-preview-5863--hpe-design-icons-grommet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Storybook stories in the Design System to use the native HTML aria-label attribute instead of Grommet's proprietary a11yTitle prop, aligning the documentation with native HTML accessibility properties.

Changes:

  • Renamed a11yTitleArg export to ariaLabelArg in common args utilities
  • Updated all component stories to use aria-label instead of a11yTitle in argTypes and args
  • Removed a11yTitle from components (Tag, Skeleton) that don't require explicit accessibility labels

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
shared/aries-core/src/stories/utils/commonArgs.tsx Renamed export from a11yTitleArg to ariaLabelArg
shared/aries-core/src/stories/components/data/Data.stories.tsx Updated Text components to use aria-label instead of a11yTitle
shared/aries-core/src/stories/components/Tip.stories.tsx Updated Button component to use aria-label
shared/aries-core/src/stories/components/Tag.stories.tsx Removed a11yTitle argType and args (not needed for Tag)
shared/aries-core/src/stories/components/Skeleton.stories.tsx Removed a11yTitle argType and args (not needed for Skeleton)
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx Updated to use aria-label in argTypes and args
shared/aries-core/src/stories/components/Select.stories.tsx Updated to use aria-label in argTypes and args
shared/aries-core/src/stories/components/RangeInput.stories.tsx Updated to use aria-label in argTypes and args
shared/aries-core/src/stories/components/Menu.stories.tsx Updated to use aria-label in argTypes and args
shared/aries-core/src/stories/components/CheckBox.stories.tsx Updated to use aria-label in argTypes and args
shared/aries-core/src/stories/components/Button.stories.tsx Updated to use aria-label in argTypes and args, removed TODO comment
shared/aries-core/src/stories/components/Avatar.stories.tsx Updated to use aria-label in argTypes and args
shared/aries-core/src/stories/components/Anchor.stories.tsx Updated to use aria-label in argTypes and args

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jcfilben jcfilben requested a review from britt6612 February 27, 2026 17:54
Copy link
Collaborator

@britt6612 britt6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

Copy link
Collaborator

@seanhillweb seanhillweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@jcfilben jcfilben merged commit 449cff0 into master Mar 5, 2026
19 of 21 checks passed
@jcfilben jcfilben deleted the sb-aria branch March 5, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants