Conversation
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates Storybook stories in the Design System to use the native HTML aria-label attribute instead of Grommet's proprietary a11yTitle prop, aligning the documentation with native HTML accessibility properties.
Changes:
- Renamed
a11yTitleArgexport toariaLabelArgin common args utilities - Updated all component stories to use
aria-labelinstead ofa11yTitlein argTypes and args - Removed
a11yTitlefrom components (Tag, Skeleton) that don't require explicit accessibility labels
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/aries-core/src/stories/utils/commonArgs.tsx | Renamed export from a11yTitleArg to ariaLabelArg |
| shared/aries-core/src/stories/components/data/Data.stories.tsx | Updated Text components to use aria-label instead of a11yTitle |
| shared/aries-core/src/stories/components/Tip.stories.tsx | Updated Button component to use aria-label |
| shared/aries-core/src/stories/components/Tag.stories.tsx | Removed a11yTitle argType and args (not needed for Tag) |
| shared/aries-core/src/stories/components/Skeleton.stories.tsx | Removed a11yTitle argType and args (not needed for Skeleton) |
| shared/aries-core/src/stories/components/SelectMultiple.stories.tsx | Updated to use aria-label in argTypes and args |
| shared/aries-core/src/stories/components/Select.stories.tsx | Updated to use aria-label in argTypes and args |
| shared/aries-core/src/stories/components/RangeInput.stories.tsx | Updated to use aria-label in argTypes and args |
| shared/aries-core/src/stories/components/Menu.stories.tsx | Updated to use aria-label in argTypes and args |
| shared/aries-core/src/stories/components/CheckBox.stories.tsx | Updated to use aria-label in argTypes and args |
| shared/aries-core/src/stories/components/Button.stories.tsx | Updated to use aria-label in argTypes and args, removed TODO comment |
| shared/aries-core/src/stories/components/Avatar.stories.tsx | Updated to use aria-label in argTypes and args |
| shared/aries-core/src/stories/components/Anchor.stories.tsx | Updated to use aria-label in argTypes and args |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
https://deploy-preview-5863--unrivaled-bublanina-3a9bae.netlify.app/
What does this PR do?
Change DS storybook stories to use aria-label instead of a11yTitle to align with the native html property. Also added react imports to stories that were missing them and did a bit of cleanup.
What are the relevant issues?
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?