Create storybook welcome page by jcfilben · Pull Request #5880 · grommet/hpe-design-system

jcfilben · 2026-03-03T22:48:18Z

https://deploy-preview-5880--unrivaled-bublanina-3a9bae.netlify.app/

What does this PR do?

Adds a welcome page to the storybook
Makes 'Components' and 'Patterns' story folders collapsed by default
Removes @storybook/react dependency and uses @storybook/react-webpack-5 instead since we are using webpack 5 with our storybook.

What are the relevant issues?

#5867

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

changeset-bot · 2026-03-03T22:48:22Z

⚠️ No Changeset found

Latest commit: e832204

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2026-03-03T22:48:23Z

✅ Deploy Preview for hpe-theme-preview ready!

Name	Link
🔨 Latest commit	`e832204`
🔍 Latest deploy log	https://app.netlify.com/projects/hpe-theme-preview/deploys/69a769258dfec20007f3c246
😎 Deploy Preview	https://deploy-preview-5880--hpe-theme-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-03-03T22:48:23Z

✅ Deploy Preview for hpe-design-icons-grommet ready!

Name	Link
🔨 Latest commit	`e832204`
🔍 Latest deploy log	https://app.netlify.com/projects/hpe-design-icons-grommet/deploys/69a76925b0e0960008b882c1
😎 Deploy Preview	https://deploy-preview-5880--hpe-design-icons-grommet.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-03-03T22:48:36Z

✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name	Link
🔨 Latest commit	`e832204`
🔍 Latest deploy log	https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/69a76925098b230008c371e4
😎 Deploy Preview	https://deploy-preview-5880--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR updates the shared/aries-core Storybook setup by adding a Welcome docs page, simplifying Storybook sidebar sorting/collapsing behavior, and aligning Storybook React dependencies/types with the webpack5 framework package.

Changes:

Added a new Welcome.mdx page intended to be the first entry in the Storybook sidebar.
Updated story files to import Meta/StoryObj types from @storybook/react-webpack5 and removed @storybook/react from dependencies.
Adjusted Storybook config for story sorting, collapsed sidebar roots, and MDX story discovery.

Reviewed changes

Copilot reviewed 49 out of 50 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
shared/aries-core/src/stories/components/data/Toolbar.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataView.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataTableGroupBy.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataTableColumns.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataTable.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataSummary.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataSort.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataSearch.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataFilters.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/DataFilter.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/data/Data.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/ToggleGroup.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Tip.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/TextInput.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/TextArea.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Tag.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Tabs.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Spinner.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Skeleton.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/SelectMultiple.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Select.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/RangeInput.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/RadioButtonGroup.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Pagination.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Page.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Notification.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/NameValueList.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Menu.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/MaskedInput.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5` (and adjust commonArgs import).
shared/aries-core/src/stories/components/Main.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Layer.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Header.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Grid.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Footer.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/FileInput.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/DateInput.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/CheckBoxGroup.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/CheckBox.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Card.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Button.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Box.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Avatar.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Anchor.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5`.
shared/aries-core/src/stories/components/Accordion.stories.tsx	Switch Storybook type imports to `@storybook/react-webpack5` (and adjust commonArgs import list).
shared/aries-core/src/Welcome.mdx	Add new Storybook welcome page content.
shared/aries-core/package.json	Remove `@storybook/react` dependency (webpack5 framework remains).
shared/aries-core/.storybook/preview.mjs	Ensure “Welcome” sorts first and simplify sort ordering.
shared/aries-core/.storybook/manager.js	Collapse “components” and “patterns” roots by default in the sidebar.
shared/aries-core/.storybook/main.mjs	Restrict MDX story glob to `../src/*.mdx` to pick up the new Welcome page.
pnpm-lock.yaml	Reflect dependency updates (including removal of `@storybook/react`).

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

pnpm-lock.yaml:656

eslint-plugin-storybook appears as a direct dependency in the lockfile, but it is not declared in any package.json in the repo. This will be removed on the next pnpm install (or indicates an incomplete dependency update). Either add it to the appropriate package.json devDependencies or regenerate the lockfile without it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shared/aries-core/src/stories/components/MaskedInput.stories.tsx

shared/aries-core/src/Welcome.mdx

Copilot

Pull request overview

Copilot reviewed 49 out of 50 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shared/aries-core/src/Welcome.mdx

shared/aries-core/.storybook/manager.js

halocline

👏 🙏

jcfilben added 2 commits March 3, 2026 15:44

Create storybook welcome page

49d39b0

remove unnecessary chage

3242c7a

jcfilben requested review from Copilot and halocline March 3, 2026 22:48

Copilot started reviewing on behalf of jcfilben March 3, 2026 22:49 View session

jcfilben mentioned this pull request Mar 3, 2026

DS storybook team review and gather feedback #5867

Open

update pnpm lock

f544bab

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Address feedback from copilot review

e832204

jcfilben requested a review from Copilot March 3, 2026 23:05

Copilot started reviewing on behalf of jcfilben March 3, 2026 23:05 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

shared/aries-core/src/Welcome.mdx Show resolved Hide resolved

shared/aries-core/.storybook/manager.js Show resolved Hide resolved

jcfilben requested a review from britt6612 March 3, 2026 23:12

halocline approved these changes Mar 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create storybook welcome page#5880

Create storybook welcome page#5880
jcfilben wants to merge 4 commits intomasterfrom
sb-landing

jcfilben commented Mar 3, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

halocline left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jcfilben commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What are the relevant issues?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Uh oh!

changeset-bot bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

netlify bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for hpe-theme-preview ready!

Uh oh!

netlify bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for hpe-design-icons-grommet ready!

Uh oh!

netlify bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

halocline left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jcfilben commented Mar 3, 2026 •

edited

Loading

changeset-bot bot commented Mar 3, 2026 •

edited

Loading

netlify bot commented Mar 3, 2026 •

edited

Loading

netlify bot commented Mar 3, 2026 •

edited

Loading

netlify bot commented Mar 3, 2026 •

edited

Loading