[GROVE-250] chore: use centrifuge lib in foreign controller#101
Merged
iamchrissmith merged 1 commit intodavid/shorten-error-stringsfrom Jan 6, 2026
Merged
[GROVE-250] chore: use centrifuge lib in foreign controller#101iamchrissmith merged 1 commit intodavid/shorten-error-stringsfrom
iamchrissmith merged 1 commit intodavid/shorten-error-stringsfrom
Conversation
iamchrissmith
changed the title
iamchrissmith
changed the title
iamchrissmith
changed the title
|
Coverage after merging fc-centrifuge-lib into david/shorten-error-strings will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
davidlee1435
approved these changes
Jan 6, 2026
Collaborator
davidlee1435
left a comment
davidlee1435
left a comment
There was a problem hiding this comment.
lgtm! verified that the logic replaced in ForeignController.transferSharesCentrifuge() matches the logic in CentrifugeLib.transferSharesCentrifuge() exactly
iamchrissmith
added a commit
that referenced
this pull request
Jan 6, 2026
This reverts commit c7ee156.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the FC had duplicate code. This makes the FC margin
2,644