Skip to content

refactor: extract RateLimitKeysLib #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
barrutko wants to merge 1 commit into from
Closed

refactor: extract RateLimitKeysLib #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions script/staging/FullStagingDeploy.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import { MainnetControllerInit } from "../../deploy/MainnetControllerInit.sol";
import { IRateLimits } from "../../src/interfaces/IRateLimits.sol";

import { RateLimitHelpers } from "../../src/RateLimitHelpers.sol";
import { RateLimitKeysLib } from "../../src/libraries/RateLimitKeysLib.sol";

import { MockJug } from "./mocks/MockJug.sol";
import { MockUsdsJoin } from "./mocks/MockUsdsJoin.sol";
Expand Down Expand Up @@ -414,23 +415,23 @@ contract FullStagingDeploy is Script {

vm.startBroadcast();

bytes32 susdeDepositKey = RateLimitHelpers.makeAssetKey(controller.LIMIT_4626_DEPOSIT(), address(controller.susde()));
bytes32 susdeDepositKey = RateLimitHelpers.makeAssetKey(RateLimitKeysLib.LIMIT_4626_DEPOSIT, address(controller.susde()));

bytes32 domainKeyArbitrum = RateLimitHelpers.makeDomainKey(controller.LIMIT_USDC_TO_DOMAIN(), CCTPForwarder.DOMAIN_ID_CIRCLE_ARBITRUM_ONE);
bytes32 domainKeyBase = RateLimitHelpers.makeDomainKey(controller.LIMIT_USDC_TO_DOMAIN(), CCTPForwarder.DOMAIN_ID_CIRCLE_BASE);
bytes32 domainKeyArbitrum = RateLimitHelpers.makeDomainKey(RateLimitKeysLib.LIMIT_USDC_TO_DOMAIN, CCTPForwarder.DOMAIN_ID_CIRCLE_ARBITRUM_ONE);
bytes32 domainKeyBase = RateLimitHelpers.makeDomainKey(RateLimitKeysLib.LIMIT_USDC_TO_DOMAIN, CCTPForwarder.DOMAIN_ID_CIRCLE_BASE);

// USDS mint/burn and cross-chain transfer rate limits
rateLimits.setRateLimitData(domainKeyBase, maxAmount6, slope6);
rateLimits.setRateLimitData(domainKeyArbitrum, maxAmount6, slope6);
rateLimits.setRateLimitData(controller.LIMIT_USDS_MINT(), maxAmount18, slope18);
rateLimits.setRateLimitData(controller.LIMIT_USDS_TO_USDC(), maxAmount6, slope6);
rateLimits.setRateLimitData(domainKeyBase, maxAmount6, slope6);
rateLimits.setRateLimitData(domainKeyArbitrum, maxAmount6, slope6);
Copy link
Copy Markdown
Collaborator

@davidlee1435 davidlee1435 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment

rateLimits.setRateLimitData(RateLimitKeysLib.LIMIT_USDS_MINT, maxAmount18, slope18);
rateLimits.setRateLimitData(RateLimitKeysLib.LIMIT_USDS_TO_USDC, maxAmount6, slope6);

rateLimits.setUnlimitedRateLimitData(controller.LIMIT_USDC_TO_CCTP());
rateLimits.setUnlimitedRateLimitData(RateLimitKeysLib.LIMIT_USDC_TO_CCTP);

// Ethena-specific rate limits
rateLimits.setRateLimitData(controller.LIMIT_SUSDE_COOLDOWN(), maxAmount18, slope18);
rateLimits.setRateLimitData(controller.LIMIT_USDE_BURN(), maxAmount18, slope18);
rateLimits.setRateLimitData(controller.LIMIT_USDE_MINT(), maxAmount6, slope6);
rateLimits.setRateLimitData(RateLimitKeysLib.LIMIT_SUSDE_COOLDOWN, maxAmount18, slope18);
rateLimits.setRateLimitData(RateLimitKeysLib.LIMIT_USDE_BURN, maxAmount18, slope18);
rateLimits.setRateLimitData(RateLimitKeysLib.LIMIT_USDE_MINT, maxAmount6, slope6);
rateLimits.setRateLimitData(susdeDepositKey, maxAmount18, slope18);

vm.stopBroadcast();
Expand All @@ -444,11 +445,11 @@ contract FullStagingDeploy is Script {

IRateLimits rateLimits = IRateLimits(controllerInst.rateLimits);

bytes32 psmDepositKey = foreignController.LIMIT_PSM_DEPOSIT();
bytes32 psmWithdrawKey = foreignController.LIMIT_PSM_WITHDRAW();
bytes32 psmDepositKey = RateLimitKeysLib.LIMIT_PSM_DEPOSIT;
bytes32 psmWithdrawKey = RateLimitKeysLib.LIMIT_PSM_WITHDRAW;

bytes32 domainKeyEthereum = RateLimitHelpers.makeDomainKey(
foreignController.LIMIT_USDC_TO_DOMAIN(),
RateLimitKeysLib.LIMIT_USDC_TO_DOMAIN,
CCTPForwarder.DOMAIN_ID_CIRCLE_ETHEREUM
);

Expand All @@ -467,7 +468,7 @@ contract FullStagingDeploy is Script {

// CCTP rate limits
rateLimits.setRateLimitData(domainKeyEthereum, maxAmount6, slope6);
rateLimits.setUnlimitedRateLimitData(foreignController.LIMIT_USDC_TO_CCTP());
rateLimits.setUnlimitedRateLimitData(RateLimitKeysLib.LIMIT_USDC_TO_CCTP);

vm.stopBroadcast();
}
Expand Down Expand Up @@ -502,8 +503,8 @@ contract FullStagingDeploy is Script {
vm.startBroadcast();

// NOTE: MainnetController and ForeignController both have the same LIMIT constants for this
bytes32 depositKey = MainnetController(controllerInst.controller).LIMIT_AAVE_DEPOSIT();
bytes32 withdrawKey = MainnetController(controllerInst.controller).LIMIT_AAVE_WITHDRAW();
bytes32 depositKey = RateLimitKeysLib.LIMIT_AAVE_DEPOSIT;
bytes32 withdrawKey = RateLimitKeysLib.LIMIT_AAVE_WITHDRAW;

IRateLimits rateLimits = IRateLimits(controllerInst.rateLimits);

Expand All @@ -526,8 +527,8 @@ contract FullStagingDeploy is Script {
vm.startBroadcast();

// NOTE: MainnetController and ForeignController both have the same LIMIT constants for this
bytes32 depositKey = MainnetController(controllerInst.controller).LIMIT_4626_DEPOSIT();
bytes32 withdrawKey = MainnetController(controllerInst.controller).LIMIT_4626_WITHDRAW();
bytes32 depositKey = RateLimitKeysLib.LIMIT_4626_DEPOSIT;
bytes32 withdrawKey = RateLimitKeysLib.LIMIT_4626_WITHDRAW;

IRateLimits rateLimits = IRateLimits(controllerInst.rateLimits);

Expand Down
5 changes: 3 additions & 2 deletions script/staging/test/FullStagingDeployment.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ import { ForeignController } from "../../../src/ForeignController.sol";
import { MainnetController } from "../../../src/MainnetController.sol";
import { RateLimits } from "../../../src/RateLimits.sol";

import { RateLimitHelpers } from "../../../src/RateLimitHelpers.sol";
import { RateLimitHelpers } from "../../../src/RateLimitHelpers.sol";
import { RateLimitKeysLib } from "../../../src/libraries/RateLimitKeysLib.sol";

interface IVatLike {
function can(address, address) external view returns (uint256);
Expand Down Expand Up @@ -353,7 +354,7 @@ contract FullMainnetStagingDeploymentTests is StagingDeploymentTestBase {
mainnetController.unstakeSUSDe();

// Handle situation where usde balance of ALM Proxy is higher than max rate limit
uint256 maxBurnAmount = rateLimits.getCurrentRateLimit(mainnetController.LIMIT_USDE_BURN());
uint256 maxBurnAmount = rateLimits.getCurrentRateLimit(RateLimitKeysLib.LIMIT_USDE_BURN);
uint256 burnAmount = usdeAmount > maxBurnAmount ? maxBurnAmount : usdeAmount;
mainnetController.prepareUSDeBurn(burnAmount);

Expand Down
5 changes: 3 additions & 2 deletions script/staging/test/MainnetStagingDeployment.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ import { ForeignController } from "../../../src/ForeignController.sol";
import { MainnetController } from "../../../src/MainnetController.sol";
import { RateLimits } from "../../../src/RateLimits.sol";

import { RateLimitHelpers } from "../../../src/RateLimitHelpers.sol";
import { RateLimitHelpers } from "../../../src/RateLimitHelpers.sol";
import { RateLimitKeysLib } from "../../../src/libraries/RateLimitKeysLib.sol";

interface IVatLike {
function can(address, address) external view returns (uint256);
Expand Down Expand Up @@ -235,7 +236,7 @@ contract MainnetStagingDeploymentTests is MainnetStagingDeploymentTestBase {
mainnetController.unstakeSUSDe();

// Handle situation where usde balance of ALM Proxy is higher than max rate limit
uint256 maxBurnAmount = rateLimits.getCurrentRateLimit(mainnetController.LIMIT_USDE_BURN());
uint256 maxBurnAmount = rateLimits.getCurrentRateLimit(RateLimitKeysLib.LIMIT_USDE_BURN);
uint256 burnAmount = usdeAmount > maxBurnAmount ? maxBurnAmount : usdeAmount;
mainnetController.prepareUSDeBurn(burnAmount);

Expand Down
Loading
Loading