Remove warnings and increase coverage#90
Merged
davidlee1435 merged 5 commits intodevfrom Dec 12, 2025
Merged
Conversation
davidlee1435
commented
Dec 11, 2025
| { | ||
| require(params.positionManager.ownerOf(params.tokenId) == address(context.proxy), "UniswapV3Lib/proxy-does-not-own-token-id"); | ||
|
|
||
| (address token0, address token1, uint24 fee, int24 tickLower, int24 tickUpper, ) = _fetchPositionData(params.tokenId, params.positionManager); |
Collaborator
Author
There was a problem hiding this comment.
unused variables
barrutko
approved these changes
Dec 11, 2025
davidlee1435
force-pushed
the
david/remove-warnings
branch
from
691d791 to
5e6c07e
Compare
davidlee1435
force-pushed
the
david/remove-warnings
branch
from
5e6c07e to
8fe4e5e
Compare
davidlee1435
force-pushed
the
david/remove-warnings
branch
from
413a6f3 to
ae1e10d
Compare
|
Coverage after merging david/remove-warnings into dev will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
barrutko
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.