Certora C-01 Cleanup: Remove redundant min amount check on add liquidity#97
Merged
davidlee1435 merged 4 commits intodevfrom Dec 22, 2025
Merged
Certora C-01 Cleanup: Remove redundant min amount check on add liquidity#97davidlee1435 merged 4 commits intodevfrom
davidlee1435 merged 4 commits intodevfrom
Conversation
davidlee1435
force-pushed
the
david/certora-c-01-cleanup
branch
from
ae43179 to
a116b72
Compare
barrutko
approved these changes
Dec 22, 2025
iamchrissmith
requested changes
Dec 22, 2025
src/libraries/UniswapV3Lib.sol
Outdated
| amountOut = _callSwap(context, params, cache); | ||
| uint256 endingBalance = IERC20(params.tokenIn).balanceOf(address(context.proxy)); | ||
| require(params.minAmountOut >= amountOut * params.maxSlippage / 1e18 , "UniswapV3Lib/min-amount-not-met"); | ||
| require(params.minAmountOut > 0, "UniswapV3Lib/min-amount-not-met"); |
There was a problem hiding this comment.
nit: this would be better moved to the top where other checks are and i think the error message should be: min-amount-not-set or similar
iamchrissmith
approved these changes
Dec 22, 2025
|
Coverage after merging david/certora-c-01-cleanup into dev will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes add liquidity spot price check as it's redundant and may trigger unintended reverts.