Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/UniswapV3Lib.sol
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,9 @@ library UniswapV3Lib {

require(pool.token0() == token0 && pool.token1() == token1 && pool.fee() == fee, "UniswapV3Lib/invalid-pool");

require(tickLower == params.tick.lower, "UniswapV3Lib/lower-tick-does-not-match-position");
require(tickUpper == params.tick.upper, "UniswapV3Lib/upper-tick-does-not-match-position");

// Check that existing position's bounds are still within governance set range
require(tickLower >= params.tickBounds.lower, "UniswapV3Lib/lower-tick-outside-bounds");
require(tickUpper <= params.tickBounds.upper, "UniswapV3Lib/upper-tick-outside-bounds");
Expand Down
70 changes: 70 additions & 0 deletions test/grove-base-fork/UniswapV3.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,76 @@ contract ForeignControllerAddLiquidityFailureTests is UniswapV3TestBase {
vm.stopPrank();
}


function test_addLiquidityUniswapV3_lowerTickDoesNotMatchPosition() public {
// Create new default position
(UniswapV3Lib.Tick memory tick, UniswapV3Lib.TokenAmounts memory desired, )
= _prepareDefaultAddLiquidity();

vm.prank(ALM_RELAYER);
(uint256 tokenId, , ,) = foreignController.addLiquidityUniswapV3(
_getPool(),
0,
tick,
desired,
_minLiquidityPosition(desired.amount0, desired.amount1),
block.timestamp + 1 hours
);

vm.warp(block.timestamp + 2 hours);

// Adding liquidity with the different lower tick bound should fail
vm.startPrank(ALM_RELAYER);
vm.expectRevert("UniswapV3Lib/lower-tick-does-not-match-position");
foreignController.addLiquidityUniswapV3(
_getPool(),
tokenId,
UniswapV3Lib.Tick({
lower: tick.lower + 1,
upper: tick.upper
}),
desired,
_minLiquidityPosition(desired.amount0, desired.amount1),
block.timestamp + 1 hours
);
vm.stopPrank();
}

function test_addLiquidityUniswapV3_upperTickDoesNotMatchPosition() public {
// Create new default position
(UniswapV3Lib.Tick memory tick, UniswapV3Lib.TokenAmounts memory desired, )
= _prepareDefaultAddLiquidity();

vm.prank(ALM_RELAYER);
(uint256 tokenId, , ,) = foreignController.addLiquidityUniswapV3(
_getPool(),
0,
tick,
desired,
_minLiquidityPosition(desired.amount0, desired.amount1),
block.timestamp + 1 hours
);

vm.warp(block.timestamp + 2 hours);

// Adding liquidity with the different upper tick bound should fail
vm.startPrank(ALM_RELAYER);
vm.expectRevert("UniswapV3Lib/upper-tick-does-not-match-position");
foreignController.addLiquidityUniswapV3(
_getPool(),
tokenId,
UniswapV3Lib.Tick({
lower: tick.lower,
upper: tick.upper + 1
}),
desired,
_minLiquidityPosition(desired.amount0, desired.amount1),
block.timestamp + 1 hours
);
vm.stopPrank();
}


function test_addLiquidityUniswapV3_failsAfterLowerTickBoundChanges() public {
// Create new default position
(UniswapV3Lib.Tick memory tick, UniswapV3Lib.TokenAmounts memory desired, )
Expand Down
Loading