Fix: Y-axis clipping uses resolution.height instead of width#161
Merged
grovesNL merged 2 commits intogrovesNL:mainfrom Dec 1, 2025
AltrixHub:fix/y-clipping-bounds
Merged
Fix: Y-axis clipping uses resolution.height instead of width#161grovesNL merged 2 commits intogrovesNL:mainfrom AltrixHub:fix/y-clipping-bounds
grovesNL merged 2 commits intogrovesNL:mainfrom
AltrixHub:fix/y-clipping-bounds
Conversation
|
👍 I was hitting this and it was driving me up a wall. Please prioritize merging this @grovesNL ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect Y-axis clipping bounds that caused text to be clipped when window height exceeded window width.
Problem
In the
prepare_with_depth_and_customfunction, the Y-axis clipping bounds incorrectly usedresolution.widthinstead ofresolution.height:https://github.com/grovesNL/glyphon/blob/2b3e0906a67e71f48b29131b25a81e46794967ca/src/text_render.rs#L154C17-L157C19