Merged
Conversation
added 3 commits
July 28, 2025 14:14
# Conflicts: # Sources/CommonMain/Features/FeaturesViewModel.swift # Sources/CommonMain/GrowthBookSDK.swift
# Conflicts: # Sources/CommonMain/Features/FeaturesViewModel.swift # Sources/CommonMain/GrowthBookSDK.swift
vazarkevych
requested review from
madhuchavva
and removed request for
madhuchavva
Contributor
|
@vazarkevych Looks like there are test failures. |
madhuchavva
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds TTL support and implements a stale-while-revalidate caching strategy for feature fetching:
Cached features are returned immediately if they are still valid.
If the cache is expired or missing, features are fetched from the network and the cache is updated.
These changes address issue , where feature data might never refresh, causing stale experiments to persist.