chore: enable several rules from govet (#773)

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yml

@@ -9,6 +9,7 @@ linters:
     - errcheck
     - errorlint
     - gocritic
+    - govet
     - misspell
     - testifylint
 
@@ -28,6 +29,11 @@ linters:
         - unnamedResult
       enable-all: true
 
+    govet:
+      disable:
+        - fieldalignment
+      enable-all: true
+
     testifylint:
       disable:
         - go-require

interceptors/client_test.go

@@ -249,7 +249,7 @@ func (s *ClientInterceptorTestSuite) TestListReporting() {
 	// Do a read, just for kicks.
 	count := 0
 	for {
-		_, err := ss.Recv()
+		_, err = ss.Recv()
 		if errors.Is(err, io.EOF) {
 			break
 		}

interceptors/protovalidate/protovalidate_test.go

@@ -38,8 +38,8 @@ func TestUnaryServerInterceptor(t *testing.T) {
 	info := &grpc.UnaryServerInfo{FullMethod: "FakeMethod"}
 
 	t.Run("valid_email", func(t *testing.T) {
-		resp, err := interceptor(context.TODO(), testvalidate.GoodUnaryRequest, info, handler)
-		require.NoError(t, err)
+		resp, interceptorError := interceptor(context.TODO(), testvalidate.GoodUnaryRequest, info, handler)
+		require.NoError(t, interceptorError)
 		assert.Equal(t, "good", resp)
 	})
 

interceptors/realip/realip.go

@@ -111,8 +111,8 @@ func getRemoteIP(ctx context.Context, trustedPeers, trustedProxies []netip.Prefi
 	if len(trustedPeers) == 0 || !ipInNets(ip, trustedPeers) {
 		return ip
 	}
-	if ip := ipFromHeaders(ctx, headers, trustedProxies, proxyCnt); ip != noIP {
-		return ip
+	if resolvedIP := ipFromHeaders(ctx, headers, trustedProxies, proxyCnt); resolvedIP != noIP {
+		return resolvedIP
 	}
 	// No ip from the headers, return the peer ip.
 	return ip

testing/testpb/pingservice_test.go

@@ -42,8 +42,8 @@ func TestPingServiceOnWire(t *testing.T) {
 
 	testClient := NewTestServiceClient(clientConn)
 	select {
-	case err := <-stopped:
-		t.Fatal("gRPC server stopped prematurely", err)
+	case clientConnErr := <-stopped:
+		t.Fatal("gRPC server stopped prematurely", clientConnErr)
 	default:
 	}
 
@@ -66,8 +66,8 @@ func TestPingServiceOnWire(t *testing.T) {
 	l, err := testClient.PingList(context.Background(), &PingListRequest{Value: "24"})
 	require.NoError(t, err)
 	for i := 0; i < ListResponseCount; i++ {
-		r, err := l.Recv()
-		require.NoError(t, err)
+		r, receiveError := l.Recv()
+		require.NoError(t, receiveError)
 		require.Equal(t, "24", r.Value)
 		require.Equal(t, int32(i), r.Counter)
 	}