Add Rust Getting Started Codelab #51
Conversation
…into rustcodelab
There was a problem hiding this comment.
Usually the .proto files are placed inside a /proto directory at the same level as /src. See tonic's health crate as an example: https://github.com/hyperium/tonic/tree/master/tonic-health
|
|
||
| message Point { | ||
| ///////////////////////////////////////////////////////////////////////////// | ||
| // Codelab Hint: Define RPC methods here |
There was a problem hiding this comment.
The comment needs to say message fields instead of "RPC methods". Same for the Feature message below.
| ```sh | ||
| $ cd tonic/protoc-gen-rust-grpc | ||
| $ bazel build //src:protoc-gen-rust-grpc | ||
| $ PLUGIN_PATH="$(pwd)/bazel-bin/src/protoc-gen-rust-grpc" |
There was a problem hiding this comment.
nit: We don't need to set PLUGIN_PATH, it's not used later.
There was a problem hiding this comment.
This should not be empty, it causes cargo build to fail.
|
|
||
|
|
There was a problem hiding this comment.
nit: Please remove extra blank lines here and at the end of the file.
| // env!("CARGO_MANIFEST_DIR"), | ||
| // "/generated/generated.rs" | ||
| // )); | ||
| // include!(concat!( |
There was a problem hiding this comment.
nit: If there's a comment for including the message code, we should also have a comment for including the service code.
| // .include("src/routeguide") | ||
| // .inputs(["routeguide.proto"]) | ||
| // .output_dir("generated") | ||
| // .compile_only() |
There was a problem hiding this comment.
nit: The compile_only option isn't present for the service codegen.
| .unwrap(); | ||
|
|
||
| // NOTE: If you were to generate code yourself, you would use the | ||
| // command below using tonic_protobuf_build's CodeGen. |
There was a problem hiding this comment.
nit: I think we should also mention that the above command should to be removed.
| async fn get_feature(&self, request: Request<Point>) -> Result<Response<Feature>, Status> { | ||
| println!("GetFeature = {:?}", request); | ||
| let requested_point = request.get_ref(); | ||
| for feature in &self.features[..] { |
There was a problem hiding this comment.
nit: for feature in self.features.iter() seems less verbose.
There was a problem hiding this comment.
In my opinion, it will be simpler to just combine this with server.rs and have the load function at the end of the file, below main.
Add Getting Started Rust Codelab
@easwars @dfawley