feat: add minimal protoc-gen-openapiv3 plugin #5811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
Aug 8, 2025
Comment on lines
+14
to
+19
| type generator struct{} | ||
|
|
||
| // New returns a new generator which generates OpenAPI v3 files. | ||
| func New() *generator { | ||
| return &generator{} | ||
| } |
There was a problem hiding this comment.
Instead of a meaningless constructor like this, lets just export the generator type.
johanbrandhorst
commented
Aug 8, 2025
| if len(b.Body.FieldPath) > 0 { | ||
| schema = schemaOfField(b.Body.FieldPath[0].Target) | ||
| } else { | ||
| // TODO(ivucica): This should be a reference to a schema in components/schemas |
There was a problem hiding this comment.
Remove this comment
johanbrandhorst
commented
Aug 8, 2025
Comment on lines
+151
to
+153
| if strings.HasSuffix(name, ".proto") { | ||
| name = name[:len(name)-len(".proto")] | ||
| } |
There was a problem hiding this comment.
Just use strings.TrimPrefix
johanbrandhorst
commented
Aug 8, 2025
| package main | ||
|
|
||
| import ( | ||
| "io/ioutil" |
There was a problem hiding this comment.
Just use io instead of ioutil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments