Fix nested schema definition for body parameter (#3058)

[ilyongcho-moloco]

References to other Issues or PRs

Fixing unnecessary nested schema definition for body parameter issue

#3058
open. -->

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

If there are no path parameters, the code now directly uses schemaOfFieldBase() to obtain the schema, without propagating target message's schema to the body parameter's schema.

Other comments

[johanbrandhorst]

Hi, thanks for this PR! Could you please add a case in an existing proto, or add a new proto that exercises this bug fix? Thanks!

[ilyongcho-moloco]

@johanbrandhorst

I updated the example.

Swagger doc with the fix applied

"/v1/{parent}/books": {
      "post": {
        "summary": "Create a book.",
        "operationId": "ABitOfEverythingService_CreateBook",
        "parameters": [
          {
            "name": "book",
            "description": "The book to create.",
            "in": "body",
            "required": true,
            "schema": {
              "$ref": "#/definitions/examplepbBook"
            }
          },
          ...
        ],
        ...
      }
    },

Swagger doc without the fix

"/v1/{parent}/books": {
      "post": {
        "summary": "Create a book.",
        "operationId": "ABitOfEverythingService_CreateBook",
        "parameters": [
          {
            "name": "book",
            "description": "The book to create.",
            "in": "body",
            "required": true,
            "schema": {
              "$ref": "#/definitions/examplepbBook",
              "required": [
                "book"
              ]
            }
          },
          ...
        ],
        ...
      }
    },

[johanbrandhorst]

LGTM

[johanbrandhorst]

Thank you for your contribution!