Warn if file reference not resolved (#412)

Author: John Luo

src/dotnet-grpc/Commands/CommandBase.cs

@@ -253,17 +253,30 @@ internal string[] GlobReferences(string[] references)
                     var directoryToSearch = Path.GetPathRoot(reference)!;
                     var searchPattern = reference.Substring(directoryToSearch.Length);
 
-                    expandedReferences.AddRange(Directory.GetFiles(directoryToSearch, searchPattern));
+                    var resolvedFiles = Directory.GetFiles(directoryToSearch, searchPattern);
+
+                    if (resolvedFiles.Length == 0)
+                    {
+                        Console.LogWarning(CoreStrings.LogWarningNoReferenceResolved, reference);
+                    }
+
+                    expandedReferences.AddRange(resolvedFiles);
                     continue;
                 }
 
                 if (Directory.Exists(Path.Combine(Project.DirectoryPath, Path.GetDirectoryName(reference)!)))
                 {
+                    var resolvedFiles = Directory.GetFiles(Project.DirectoryPath, reference);
+
+                    if (resolvedFiles.Length == 0)
+                    {
+                        Console.LogWarning(CoreStrings.LogWarningNoReferenceResolved, reference);
+                    }
+
                     expandedReferences.AddRange(
-                        Directory.GetFiles(Project.DirectoryPath, reference)
-                            // The reference is relative to the project directory but GetFiles returns the full path.
-                            // Remove the project directory portion of the path so relative references are maintained.
-                            .Select(r => r.Replace(Project.DirectoryPath + Path.DirectorySeparatorChar, string.Empty)));
+                        // The reference is relative to the project directory but GetFiles returns the full path.
+                        // Remove the project directory portion of the path so relative references are maintained.
+                        resolvedFiles.Select(r => r.Replace(Project.DirectoryPath + Path.DirectorySeparatorChar, string.Empty)));
                 }
             }
 

src/dotnet-grpc/Properties/CoreStrings.Designer.cs

@@ -207,4 +207,7 @@
   <data name="ErrorOutputMustBeFilePath" xml:space="preserve">
     <value>Output path `{0}` is invalid. The path cannot be a directory path and must be a file path.</value>
   </data>
+  <data name="LogWarningNoReferenceResolved" xml:space="preserve">
+    <value>No file found matching file argument `{0}`. File reference not added.</value>
+  </data>
 </root>

src/dotnet-grpc/Properties/CoreStrings.resx

@@ -23,6 +23,7 @@
 using Grpc.Dotnet.Cli.Commands;
 using Grpc.Dotnet.Cli.Internal;
 using Grpc.Dotnet.Cli.Options;
+using Grpc.Dotnet.Cli.Properties;
 using Grpc.Tests.Shared;
 using Microsoft.Build.Definition;
 using Microsoft.Build.Evaluation;
@@ -318,33 +319,39 @@ public void ResolveServices_ReturnsClient_IfNotWebSDK()
         }
 
         [Test]
-        public void GlobReferences_ExpandsRelativeReferences()
+        public void GlobReferences_ExpandsRelativeReferences_WarnsIfReferenceNotResolved()
         {
             // Arrange
+            var testConsole = new TestConsole();
             var commandBase = new CommandBase(
-                new TestConsole(),
+                testConsole,
                 CreateIsolatedProject(Path.Combine(Directory.GetCurrentDirectory(), "TestAssets", "EmptyProject", "test.csproj")));
+            var invalidReference = Path.Combine("Proto", "invalid*reference.proto");
 
             // Act
-            var references = commandBase.GlobReferences(new[] { Path.Combine("Proto", "*.proto") });
+            var references = commandBase.GlobReferences(new[] { Path.Combine("Proto", "*.proto"), invalidReference });
 
             // Assert
             Assert.Contains(Path.Combine("Proto", "a.proto"), references);
             Assert.Contains(Path.Combine("Proto", "b.proto"), references);
+            Assert.AreEqual($"Warning: {string.Format(CoreStrings.LogWarningNoReferenceResolved, invalidReference, SourceUrl)}", testConsole.Out.ToString()!.TrimEnd());
         }
 
         [Test]
-        public void GlobReferences_ExpandsAbsoluteReferences()
+        public void GlobReferences_ExpandsAbsoluteReferences_WarnsIfReferenceNotResolved()
         {
             // Arrange
-            var commandBase = new CommandBase(new TestConsole(), new Project());
+            var testConsole = new TestConsole();
+            var commandBase = new CommandBase(testConsole, new Project());
+            var invalidReference = Path.Combine(Directory.GetCurrentDirectory(), "TestAssets", "EmptyProject", "Proto", "invalid*reference.proto");
 
             // Act
-            var references = commandBase.GlobReferences(new[] { Path.Combine(Directory.GetCurrentDirectory(), "TestAssets", "EmptyProject", "Proto", "*.proto") });
+            var references = commandBase.GlobReferences(new[] { Path.Combine(Directory.GetCurrentDirectory(), "TestAssets", "EmptyProject", "Proto", "*.proto"), invalidReference });
 
             // Assert
             Assert.Contains(Path.Combine(Directory.GetCurrentDirectory(), "TestAssets", "EmptyProject", "Proto", "a.proto"), references);
             Assert.Contains(Path.Combine(Directory.GetCurrentDirectory(), "TestAssets", "EmptyProject", "Proto", "b.proto"), references);
+            Assert.AreEqual($"Warning: {string.Format(CoreStrings.LogWarningNoReferenceResolved, invalidReference, SourceUrl)}", testConsole.Out.ToString()!.TrimEnd());
         }
 
         static object[] DirectoryPaths =