Skip to content

Fix typo in comment about socket ping scheduling #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasoob wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo in comment about socket ping scheduling #2671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Grpc.Net.Client/Balancer/Internal/SocketConnectivitySubchannelTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public async ValueTask<ConnectResult> TryConnectAsync(ConnectContext context, in
_initialSocketData = null;
_initialSocketCreatedTime = DateTime.UtcNow;

// Schedule ping. Don't set a periodic interval to avoid any chance of timer causing the target method to run multiple times in paralle.
// Schedule ping. Don't set a periodic interval to avoid any chance of timer causing the target method to run multiple times in parallel.
// This could happen because of execution delays (e.g. hitting a debugger breakpoint).
// Instead, the socket timer target method reschedules the next run after it has finished.
_socketConnectedTimer.Change(_socketPingInterval, Timeout.InfiniteTimeSpan);
Expand Down