Skip to content

Conversation

vinothkumarr227
Copy link
Contributor

@vinothkumarr227 vinothkumarr227 commented Aug 18, 2025

Fixes: #8485

RELEASE NOTES:

  • client: Ignore http headers with status 1xx and END_STREAM flag unset.
  • client: Fail RPCs with status INTERNAL instead of UNKNOWN on receiving http headers with status 1xx and END_STREAM flag set.

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (9ac0ec8) to head (7dac9dd).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8518      +/-   ##
==========================================
+ Coverage   81.82%   81.94%   +0.12%     
==========================================
  Files         413      412       -1     
  Lines       40518    40469      -49     
==========================================
+ Hits        33153    33163      +10     
+ Misses       5989     5915      -74     
- Partials     1376     1391      +15     
Files with missing lines Coverage Δ
internal/transport/http2_client.go 91.84% <100.00%> (+0.02%) ⬆️

... and 238 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal added the Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. label Aug 20, 2025
@arjan-bal arjan-bal added this to the 1.76 Release milestone Aug 20, 2025
@arjan-bal arjan-bal changed the title client transport: Handle 1xx HTTP status HEADERS frames correctly transport: handle 1xx HTTP status HEADERS at the client side Aug 20, 2025
@vinothkumarr227 vinothkumarr227 removed their assignment Aug 26, 2025
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small changes, otherwise LGTM. Please address them before I add a second reviewer.

@vinothkumarr227 vinothkumarr227 removed their assignment Aug 29, 2025
@arjan-bal arjan-bal requested a review from dfawley August 29, 2025 08:17
@arjan-bal arjan-bal removed the Area: Client Includes Channel/Subchannel/Streams, Connectivity States, RPC Retries, Dial/Call Options and more. label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client transport: Handle 1xx HTTP status HEADERS frames correctly
3 participants