Skip to content

credentials: Allow net.Pipe with credentials/local #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+13 −0
Open

credentials: Allow net.Pipe with credentials/local #8603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2062bcd
credentials: Allow net.Pipe with credentials/local
Ongy Sep 23, 2025
97dd7f8
fix typo
Ongy Sep 23, 2025
58a2a60
Add windows test
Ongy Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions credentials/local/local.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ func getSecurityLevel(network, addr string) (credentials.SecurityLevel, error) {
// Windows named pipe connection
case network == "pipe" && strings.HasPrefix(addr, `\\.\pipe\`):
return credentials.NoSecurity, nil
// Go net.Pipe connection
case network == "pipe" && addr == "pipe":
return credentials.NoSecurity, nil
// UDS connection
case network == "unix":
return credentials.PrivacyAndIntegrity, nil
Expand Down
10 changes: 10 additions & 0 deletions credentials/local/local_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ func (s) TestGetSecurityLevel(t *testing.T) {
testAddr: "[::1]:10000",
want: credentials.NoSecurity,
},
{
testNetwork: "pipe",
testAddr: `\\.\pipe\foo`,
want: credentials.NoSecurity,
},
{
testNetwork: "pipe",
testAddr: "pipe",
want: credentials.NoSecurity,
},
{
testNetwork: "unix",
testAddr: "/tmp/grpc_fullstack_test",
Expand Down