benchmark/client: add context for cancellation #8614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8614 +/- ##
==========================================
+ Coverage 81.96% 82.04% +0.07%
==========================================
Files 415 415
Lines 40694 40694
==========================================
+ Hits 33355 33387 +32
+ Misses 5950 5946 -4
+ Partials 1389 1361 -28 🚀 New features to boost your workflow:
|
|
Could you please add "Type: Internal Cleanup" label? Thanks |
| select { | ||
| case <-bc.stop: | ||
| if bc.ctx.Err() != nil { | ||
| return |
There was a problem hiding this comment.
Can we change it to return bc.ctx.Err() and change function unaryLoop to return error?
There was a problem hiding this comment.
I believe we can, but error is happening inside a goroutine and I'm not quite sure how to implement handling. Could you suggest an approach?
| if err := benchmark.DoUnaryCall(client, reqSize, respSize); err != nil { | ||
| if err := benchmark.DoUnaryCallWithContext(bc.ctx, client, reqSize, respSize); err != nil { | ||
| if status.Code(err) == codes.Canceled || errors.Is(err, context.Canceled) { | ||
| return |
There was a problem hiding this comment.
Any specific reason for not changing the return type of unaryLoop to return ctx.Err()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8596
Added cancellation by context in benchmark/client instead of custom channel approach. Not sure about returning
ctx.Err()(as mentioned in the original issue under point 4), so please reviewRELEASE NOTES: None