Skip to content

binarylog: replace testServer with StubServer in binarylog_end2end_test.go#8978

Open
110y wants to merge 2 commits intogrpc:masterfrom
110y:7291-use-stubserver-binary-log
Open

binarylog: replace testServer with StubServer in binarylog_end2end_test.go#8978
110y wants to merge 2 commits intogrpc:masterfrom
110y:7291-use-stubserver-binary-log

Conversation

@110y
Copy link
Contributor

@110y 110y commented Mar 17, 2026

RELEASE NOTES: none

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.97%. Comparing base (36e13de) to head (d212ea6).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8978      +/-   ##
==========================================
- Coverage   83.01%   82.97%   -0.05%     
==========================================
  Files         411      411              
  Lines       32719    32892     +173     
==========================================
+ Hits        27162    27291     +129     
- Misses       4167     4200      +33     
- Partials     1390     1401      +11     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are here, would you mind changing the clientconn method on test and instead do the following:

  • In test.startServer call stubserver.Start() instead of StartServer()
    • This would also end up creating a ClientConn to the newly created stub server
  • In test.clientconn, return stubserver.CC
  • Or optionally, get rid of this test.clientconn method and directly use test.ss.CC if possible.
  • Either way is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I got rid of test.clientConn (and test.tearDown): d212ea6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants