grpclb: replace testServer with StubServer in grpclb_test.go#8979
Open
110y wants to merge 2 commits intogrpc:masterfrom
Open
grpclb: replace testServer with StubServer in grpclb_test.go#8979110y wants to merge 2 commits intogrpc:masterfrom
110y wants to merge 2 commits intogrpc:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8979 +/- ##
==========================================
+ Coverage 83.01% 83.09% +0.07%
==========================================
Files 411 411
Lines 32719 32733 +14
==========================================
+ Hits 27162 27198 +36
+ Misses 4167 4150 -17
+ Partials 1390 1385 -5 🚀 New features to boost your workflow:
|
easwars
reviewed
Mar 17, 2026
balancer/grpclb/grpclb_test.go
Outdated
Comment on lines
327
to
330
Contributor
There was a problem hiding this comment.
Can we instead pass the listener to the stubserver and call StartServer method on it instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc.Serverorxds.GRPCServer#7291RELEASE NOTES: none