Skip to content

Make AddressFilter public to allow use of "weighted_target_experimental" (Fixes #12265) #12267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make AddressFilter public to allow use of "weighted_target_experimental" (Fixes #12265) #12267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions xds/src/main/java/io/grpc/xds/AddressFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import java.util.List;
import javax.annotation.Nullable;

final class AddressFilter {
public final class AddressFilter {
@ResolutionResultAttr
private static final Attributes.Key<PathChain> PATH_CHAIN_KEY =
Attributes.Key.create("io.grpc.xds.AddressFilter.PATH_CHAIN_KEY");
Expand All @@ -38,7 +38,7 @@ private AddressFilter() {}
* Returns a new EquivalentAddressGroup by setting a path filter to the given
* EquivalentAddressGroup. This method does not modify the input address.
*/
static EquivalentAddressGroup setPathFilter(EquivalentAddressGroup address, List<String> names) {
public static EquivalentAddressGroup setPathFilter(EquivalentAddressGroup address, List<String> names) {
checkNotNull(address, "address");
checkNotNull(names, "names");
Attributes.Builder attrBuilder = address.getAttributes().toBuilder().discard(PATH_CHAIN_KEY);
Expand Down Expand Up @@ -75,11 +75,11 @@ static List<EquivalentAddressGroup> filter(List<EquivalentAddressGroup> addresse
return Collections.unmodifiableList(filteredAddresses);
}

private static final class PathChain {
public static final class PathChain {
final String name;
@Nullable PathChain next;

PathChain(String name) {
public PathChain(String name) {
this.name = checkNotNull(name, "name");
}

Expand Down
Loading