Skip to content

Add compatibility for php 8.4 by removing deprecation warnings #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add compatibility for php 8.4 by removing deprecation warnings #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/ServerCallWriter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function finish(

private function addSendInitialMetadataOpIfNotSent(
array &$batch,
array $initialMetadata = null
$initialMetadata = null
) {
if (!$this->initialMetadataSent_) {
$batch[OP_SEND_INITIAL_METADATA] = $initialMetadata ?? [];
Expand Down
4 changes: 2 additions & 2 deletions src/lib/Status.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
*/
class Status
{
public static function status(int $code, string $details, array $metadata = null): array
public static function status(int $code, string $details, $metadata = null): array
{
$status = [
'code' => $code,
Expand All @@ -44,7 +44,7 @@ public static function status(int $code, string $details, array $metadata = null
return $status;
}

public static function ok(array $metadata = null): array
public static function ok($metadata = null): array
{
return Status::status(STATUS_OK, 'OK', $metadata);
}
Expand Down